From 23ab5c5cc0bfac56260acc2be982e594eaaeaffe Mon Sep 17 00:00:00 2001
From: Deepesh Garg <deepeshgarg6@gmail.com>
Date: Thu, 31 Dec 2020 11:29:06 +0530
Subject: [PATCH] fix: Multiplle sider issues

---
 erpnext/accounts/doctype/budget/budget.js                 | 4 ++--
 erpnext/education/doctype/fees/fees.js                    | 4 ++--
 erpnext/hr/doctype/expense_claim/expense_claim.js         | 2 +-
 erpnext/public/js/queries.js                              | 2 +-
 erpnext/public/js/utils.js                                | 2 +-
 erpnext/public/js/utils/dimension_tree_filter.js          | 8 ++++----
 .../doctype/stock_reconciliation/stock_reconciliation.js  | 2 +-
 7 files changed, 12 insertions(+), 12 deletions(-)

diff --git a/erpnext/accounts/doctype/budget/budget.js b/erpnext/accounts/doctype/budget/budget.js
index e60bc60475e..e162e3222d3 100644
--- a/erpnext/accounts/doctype/budget/budget.js
+++ b/erpnext/accounts/doctype/budget/budget.js
@@ -11,7 +11,7 @@ frappe.ui.form.on('Budget', {
 					report_type: "Profit and Loss",
 					is_group: 0
 				}
-			}
+			};
 		});
 
 		frm.set_query("monthly_distribution", function() {
@@ -19,7 +19,7 @@ frappe.ui.form.on('Budget', {
 				filters: {
 					fiscal_year: frm.doc.fiscal_year
 				}
-			}
+			};
 		});
 
 		erpnext.accounts.dimensions.setup_dimension_filters(frm, frm.doctype);
diff --git a/erpnext/education/doctype/fees/fees.js b/erpnext/education/doctype/fees/fees.js
index 433bd64d2fb..40f50999adf 100644
--- a/erpnext/education/doctype/fees/fees.js
+++ b/erpnext/education/doctype/fees/fees.js
@@ -15,9 +15,9 @@ frappe.ui.form.on("Fees", {
 	},
 
 	onload: function(frm){
-		frm.set_query("academic_term",function(){
+		frm.set_query("academic_term",function() {
 			return{
-				"filters":{
+				"filters": {
 					"academic_year": (frm.doc.academic_year)
 				}
 			};
diff --git a/erpnext/hr/doctype/expense_claim/expense_claim.js b/erpnext/hr/doctype/expense_claim/expense_claim.js
index e399b22f90f..629341ff2a5 100644
--- a/erpnext/hr/doctype/expense_claim/expense_claim.js
+++ b/erpnext/hr/doctype/expense_claim/expense_claim.js
@@ -16,7 +16,7 @@ frappe.ui.form.on('Expense Claim', {
 frappe.ui.form.on('Expense Claim Detail', {
 	expense_type: function(frm, cdt, cdn) {
 		var d = locals[cdt][cdn];
-		if(!frm.doc.company) {
+		if (!frm.doc.company) {
 			d.expense_type = "";
 			frappe.msgprint(__("Please set the Company"));
 			this.frm.refresh_fields();
diff --git a/erpnext/public/js/queries.js b/erpnext/public/js/queries.js
index 98f1b504ccc..b635adcd443 100644
--- a/erpnext/public/js/queries.js
+++ b/erpnext/public/js/queries.js
@@ -115,7 +115,7 @@ $.extend(erpnext.queries, {
 				["Warehouse", "is_group", "=",0]
 
 			]
-		}
+		};
 	},
 
 	get_filtered_dimensions: function(doc, child_fields, dimension, company) {
diff --git a/erpnext/public/js/utils.js b/erpnext/public/js/utils.js
index 2635d47f886..c39609bd389 100755
--- a/erpnext/public/js/utils.js
+++ b/erpnext/public/js/utils.js
@@ -202,7 +202,7 @@ $.extend(erpnext.utils, {
 					let found = filters.some(el => el.fieldname === dimension['fieldname']);
 
 					if (!found) {
-						filters.splice(index, 0 ,{
+						filters.splice(index, 0, {
 							"fieldname": dimension["fieldname"],
 							"label": __(dimension["label"]),
 							"fieldtype": "Link",
diff --git a/erpnext/public/js/utils/dimension_tree_filter.js b/erpnext/public/js/utils/dimension_tree_filter.js
index c79736d0e19..319cbd2b5d5 100644
--- a/erpnext/public/js/utils/dimension_tree_filter.js
+++ b/erpnext/public/js/utils/dimension_tree_filter.js
@@ -69,13 +69,13 @@ erpnext.accounts.dimensions = {
 	update_dimension(frm, doctype) {
 		if (this.accounting_dimensions) {
 			this.accounting_dimensions.forEach((dimension) => {
-				if(frm.is_new()) {
-					if(frm.doc.company && Object.keys(this.default_dimensions || {}).length > 0
+				if (frm.is_new()) {
+					if (frm.doc.company && Object.keys(this.default_dimensions || {}).length > 0
 						&& this.default_dimensions[frm.doc.company]) {
 
 						let default_dimension = this.default_dimensions[frm.doc.company][dimension['fieldname']];
 
-						if(default_dimension) {
+						if (default_dimension) {
 							if (frappe.meta.has_field(doctype, dimension['fieldname'])) {
 								frm.set_value(dimension['fieldname'], default_dimension);
 							}
@@ -98,4 +98,4 @@ erpnext.accounts.dimensions = {
 			});
 		}
 	}
-}
\ No newline at end of file
+};
\ No newline at end of file
diff --git a/erpnext/stock/doctype/stock_reconciliation/stock_reconciliation.js b/erpnext/stock/doctype/stock_reconciliation/stock_reconciliation.js
index be9404d9c8c..ac4ed5e75d9 100644
--- a/erpnext/stock/doctype/stock_reconciliation/stock_reconciliation.js
+++ b/erpnext/stock/doctype/stock_reconciliation/stock_reconciliation.js
@@ -2,7 +2,7 @@
 // License: GNU General Public License v3. See license.txt
 
 frappe.provide("erpnext.stock");
-frappe.provide("erpnext.accounts.dimensions")
+frappe.provide("erpnext.accounts.dimensions");
 
 frappe.ui.form.on("Stock Reconciliation", {
 	onload: function(frm) {