diff --git a/erpnext/patches/v14_0/migrate_crm_settings.py b/erpnext/patches/v14_0/migrate_crm_settings.py index d093bc386e0..e928626d3ca 100644 --- a/erpnext/patches/v14_0/migrate_crm_settings.py +++ b/erpnext/patches/v14_0/migrate_crm_settings.py @@ -2,11 +2,7 @@ import frappe def execute(): - settings = frappe.db.get_single_value( - "Selling Settings", - ["campaign_naming_by", "close_opportunity_after_days", "default_valid_till"], - as_dict=True, - ) + settings = frappe.db.get_singles_dict("Selling Settings", cast=True) frappe.reload_doc("crm", "doctype", "crm_settings") if settings: diff --git a/erpnext/stock/doctype/repost_item_valuation/repost_item_valuation.py b/erpnext/stock/doctype/repost_item_valuation/repost_item_valuation.py index 909aa367101..159166237c5 100644 --- a/erpnext/stock/doctype/repost_item_valuation/repost_item_valuation.py +++ b/erpnext/stock/doctype/repost_item_valuation/repost_item_valuation.py @@ -140,9 +140,7 @@ class RepostItemValuation(Document): return query[0][0] if query else None def validate_accounts_freeze(self): - acc_settings = frappe.db.get_single_value( - "Accounts Settings", ["acc_frozen_upto", "frozen_accounts_modifier"], as_dict=1 - ) + acc_settings = frappe.db.get_singles_dict("Accounts Settings", cast=True) if not acc_settings.acc_frozen_upto: return if getdate(self.posting_date) <= getdate(acc_settings.acc_frozen_upto): diff --git a/erpnext/utilities/doctype/video/video.py b/erpnext/utilities/doctype/video/video.py index 7a04329cb98..060eb075463 100644 --- a/erpnext/utilities/doctype/video/video.py +++ b/erpnext/utilities/doctype/video/video.py @@ -78,14 +78,12 @@ def get_frequency(value): def update_youtube_data(): # Called every 30 minutes via hooks - enable_youtube_tracking, frequency = frappe.db.get_single_value( - "Video Settings", ["enable_youtube_tracking", "frequency"] - ) + video_settings = frappe.db.get_singles_dict("Video Settings", cast=True) - if not cint(enable_youtube_tracking): + if not video_settings.enable_youtube_tracking: return - frequency = get_frequency(frequency) + frequency = get_frequency(video_settings.frequency) time = datetime.now() timezone = pytz.timezone(get_system_timezone()) site_time = time.astimezone(timezone)