From 835c85a0877b03a3c73f2a11a505091f357621c5 Mon Sep 17 00:00:00 2001 From: Gursheen Anand Date: Tue, 28 Nov 2023 15:42:30 +0530 Subject: [PATCH 1/4] feat: add currency column for allocated entries --- .../payment_reconciliation_allocation.json | 19 +++++++++++++------ 1 file changed, 13 insertions(+), 6 deletions(-) diff --git a/erpnext/accounts/doctype/payment_reconciliation_allocation/payment_reconciliation_allocation.json b/erpnext/accounts/doctype/payment_reconciliation_allocation/payment_reconciliation_allocation.json index 6a21692c6ac..9eed7b1c82a 100644 --- a/erpnext/accounts/doctype/payment_reconciliation_allocation/payment_reconciliation_allocation.json +++ b/erpnext/accounts/doctype/payment_reconciliation_allocation/payment_reconciliation_allocation.json @@ -20,7 +20,8 @@ "section_break_5", "difference_amount", "column_break_7", - "difference_account" + "difference_account", + "currency" ], "fields": [ { @@ -37,7 +38,7 @@ "fieldtype": "Currency", "in_list_view": 1, "label": "Allocated Amount", - "options": "Currency", + "options": "currency", "reqd": 1 }, { @@ -64,7 +65,7 @@ "fieldtype": "Currency", "in_list_view": 1, "label": "Difference Amount", - "options": "Currency", + "options": "currency", "read_only": 1 }, { @@ -112,7 +113,7 @@ "fieldtype": "Currency", "hidden": 1, "label": "Unreconciled Amount", - "options": "Currency", + "options": "currency", "read_only": 1 }, { @@ -120,7 +121,7 @@ "fieldtype": "Currency", "hidden": 1, "label": "Amount", - "options": "Currency", + "options": "currency", "read_only": 1 }, { @@ -129,11 +130,17 @@ "hidden": 1, "label": "Reference Row", "read_only": 1 + }, + { + "fieldname": "currency", + "fieldtype": "Link", + "label": "Currency", + "options": "Currency" } ], "istable": 1, "links": [], - "modified": "2021-10-06 11:48:59.616562", + "modified": "2023-11-28 15:37:42.336096", "modified_by": "Administrator", "module": "Accounts", "name": "Payment Reconciliation Allocation", From 3dfc1450a1551640c6105040e8425b8e3c933b63 Mon Sep 17 00:00:00 2001 From: Gursheen Anand Date: Tue, 28 Nov 2023 15:43:36 +0530 Subject: [PATCH 2/4] fix: update voucher currency for allocated entry --- .../doctype/payment_reconciliation/payment_reconciliation.py | 1 + 1 file changed, 1 insertion(+) diff --git a/erpnext/accounts/doctype/payment_reconciliation/payment_reconciliation.py b/erpnext/accounts/doctype/payment_reconciliation/payment_reconciliation.py index 1e99e4d791c..d7274d7d317 100644 --- a/erpnext/accounts/doctype/payment_reconciliation/payment_reconciliation.py +++ b/erpnext/accounts/doctype/payment_reconciliation/payment_reconciliation.py @@ -295,6 +295,7 @@ class PaymentReconciliation(Document): "amount": pay.get("amount"), "allocated_amount": allocated_amount, "difference_amount": pay.get("difference_amount"), + "currency": inv.get("currency"), } ) From b7944a7c075f50e652860a2c89bda8e639b64c8d Mon Sep 17 00:00:00 2001 From: Gursheen Anand Date: Tue, 28 Nov 2023 15:51:33 +0530 Subject: [PATCH 3/4] chore: hide currency column --- .../payment_reconciliation_allocation.json | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/erpnext/accounts/doctype/payment_reconciliation_allocation/payment_reconciliation_allocation.json b/erpnext/accounts/doctype/payment_reconciliation_allocation/payment_reconciliation_allocation.json index 9eed7b1c82a..fec8a6d4c7d 100644 --- a/erpnext/accounts/doctype/payment_reconciliation_allocation/payment_reconciliation_allocation.json +++ b/erpnext/accounts/doctype/payment_reconciliation_allocation/payment_reconciliation_allocation.json @@ -134,13 +134,14 @@ { "fieldname": "currency", "fieldtype": "Link", + "hidden": 1, "label": "Currency", "options": "Currency" } ], "istable": 1, "links": [], - "modified": "2023-11-28 15:37:42.336096", + "modified": "2023-11-28 15:50:42.336096", "modified_by": "Administrator", "module": "Accounts", "name": "Payment Reconciliation Allocation", From 6f44a1630f56a940dda7ff69cf9e9d06040ae813 Mon Sep 17 00:00:00 2001 From: Gursheen Anand Date: Tue, 28 Nov 2023 16:31:40 +0530 Subject: [PATCH 4/4] fix: show difference amount in default currency --- .../payment_reconciliation_allocation.json | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/erpnext/accounts/doctype/payment_reconciliation_allocation/payment_reconciliation_allocation.json b/erpnext/accounts/doctype/payment_reconciliation_allocation/payment_reconciliation_allocation.json index fec8a6d4c7d..7b94eb0ea4a 100644 --- a/erpnext/accounts/doctype/payment_reconciliation_allocation/payment_reconciliation_allocation.json +++ b/erpnext/accounts/doctype/payment_reconciliation_allocation/payment_reconciliation_allocation.json @@ -65,7 +65,7 @@ "fieldtype": "Currency", "in_list_view": 1, "label": "Difference Amount", - "options": "currency", + "options": "Currency", "read_only": 1 }, { @@ -141,7 +141,7 @@ ], "istable": 1, "links": [], - "modified": "2023-11-28 15:50:42.336096", + "modified": "2023-11-28 16:30:43.344612", "modified_by": "Administrator", "module": "Accounts", "name": "Payment Reconciliation Allocation",