mirror of
https://github.com/frappe/erpnext.git
synced 2026-03-24 21:52:21 +01:00
fix(fiscal_year): Fiscal Year auto-generation and notification
(cherry picked from commit 4c76786ce4)
# Conflicts:
# erpnext/accounts/doctype/fiscal_year/fiscal_year.py
# erpnext/accounts/notification/notification_for_new_fiscal_year/notification_for_new_fiscal_year.html
# erpnext/accounts/notification/notification_for_new_fiscal_year/notification_for_new_fiscal_year.json
This commit is contained in:
@@ -4,7 +4,7 @@
|
|||||||
|
|
||||||
import frappe
|
import frappe
|
||||||
from dateutil.relativedelta import relativedelta
|
from dateutil.relativedelta import relativedelta
|
||||||
from frappe import _
|
from frappe import _, cint
|
||||||
from frappe.model.document import Document
|
from frappe.model.document import Document
|
||||||
from frappe.utils import add_days, add_years, cstr, getdate
|
from frappe.utils import add_days, add_years, cstr, getdate
|
||||||
|
|
||||||
@@ -89,6 +89,7 @@ class FiscalYear(Document):
|
|||||||
)
|
)
|
||||||
|
|
||||||
|
|
||||||
|
<<<<<<< HEAD
|
||||||
@frappe.whitelist()
|
@frappe.whitelist()
|
||||||
<<<<<<< HEAD
|
<<<<<<< HEAD
|
||||||
def check_duplicate_fiscal_year(doc):
|
def check_duplicate_fiscal_year(doc):
|
||||||
@@ -110,14 +111,27 @@ def check_duplicate_fiscal_year(doc):
|
|||||||
@frappe.whitelist()
|
@frappe.whitelist()
|
||||||
=======
|
=======
|
||||||
>>>>>>> 74ac28fc70 (refactor: `Fiscal Year` DocType cleanup)
|
>>>>>>> 74ac28fc70 (refactor: `Fiscal Year` DocType cleanup)
|
||||||
|
=======
|
||||||
|
>>>>>>> 4c76786ce4 (fix(`fiscal_year`): `Fiscal Year` auto-generation and notification)
|
||||||
def auto_create_fiscal_year():
|
def auto_create_fiscal_year():
|
||||||
for d in frappe.db.sql(
|
fy = frappe.qb.DocType("Fiscal Year")
|
||||||
"""select name from `tabFiscal Year` where year_end_date = date_add(current_date, interval 3 day)"""
|
|
||||||
):
|
# Skipped auto-creating Short Year, as it has very rare use case.
|
||||||
|
# Reference: https://www.irs.gov/businesses/small-businesses-self-employed/tax-years (US)
|
||||||
|
follow_up_date = add_days(getdate(), days=3)
|
||||||
|
fiscal_year = (
|
||||||
|
frappe.qb.from_(fy)
|
||||||
|
.select(fy.name)
|
||||||
|
.where((fy.year_end_date == follow_up_date) & (fy.is_short_year == 0))
|
||||||
|
.run()
|
||||||
|
)
|
||||||
|
|
||||||
|
for d in fiscal_year:
|
||||||
try:
|
try:
|
||||||
current_fy = frappe.get_doc("Fiscal Year", d[0])
|
current_fy = frappe.get_doc("Fiscal Year", d[0])
|
||||||
|
|
||||||
new_fy = frappe.copy_doc(current_fy, ignore_no_copy=False)
|
new_fy = frappe.new_doc("Fiscal Year")
|
||||||
|
new_fy.disabled = cint(current_fy.disabled)
|
||||||
|
|
||||||
new_fy.year_start_date = add_days(current_fy.year_end_date, 1)
|
new_fy.year_start_date = add_days(current_fy.year_end_date, 1)
|
||||||
new_fy.year_end_date = add_years(current_fy.year_end_date, 1)
|
new_fy.year_end_date = add_years(current_fy.year_end_date, 1)
|
||||||
@@ -125,6 +139,10 @@ def auto_create_fiscal_year():
|
|||||||
start_year = cstr(new_fy.year_start_date.year)
|
start_year = cstr(new_fy.year_start_date.year)
|
||||||
end_year = cstr(new_fy.year_end_date.year)
|
end_year = cstr(new_fy.year_end_date.year)
|
||||||
new_fy.year = start_year if start_year == end_year else (start_year + "-" + end_year)
|
new_fy.year = start_year if start_year == end_year else (start_year + "-" + end_year)
|
||||||
|
|
||||||
|
for row in current_fy.companies:
|
||||||
|
new_fy.append("companies", {"company": row.company})
|
||||||
|
|
||||||
new_fy.auto_created = 1
|
new_fy.auto_created = 1
|
||||||
|
|
||||||
new_fy.insert(ignore_permissions=True)
|
new_fy.insert(ignore_permissions=True)
|
||||||
|
|||||||
@@ -0,0 +1,43 @@
|
|||||||
|
<h4>{{ _("New Fiscal Year - {0}").format(doc.name) }}</h4>
|
||||||
|
|
||||||
|
<p>{{ _("A new fiscal year has been automatically created.") }}</p>
|
||||||
|
|
||||||
|
<p>{{ _("Fiscal Year Details") }}</p>
|
||||||
|
|
||||||
|
<table style="margin-bottom: 1rem; width: 70%">
|
||||||
|
<tr>
|
||||||
|
<td style="font-weight:bold; width: 40%">{{ _("Year Name") }}</td>
|
||||||
|
<td>{{ doc.name }}</td>
|
||||||
|
</tr>
|
||||||
|
<tr>
|
||||||
|
<td style="font-weight:bold; width: 40%">{{ _("Start Date") }}</td>
|
||||||
|
<td>{{ frappe.format_value(doc.year_start_date) }}</td>
|
||||||
|
</tr>
|
||||||
|
<tr>
|
||||||
|
<td style="font-weight:bold; width: 40%">{{ _("End Date") }}</td>
|
||||||
|
<td>{{ frappe.format_value(doc.year_end_date) }}</td>
|
||||||
|
</tr>
|
||||||
|
{% if doc.companies|length > 0 %}
|
||||||
|
<tr>
|
||||||
|
<td style="vertical-align: top; font-weight: bold; width: 40%" rowspan="{{ doc.companies|length }}">
|
||||||
|
{% if doc.companies|length < 2 %}
|
||||||
|
{{ _("Company") }}
|
||||||
|
{% else %}
|
||||||
|
{{ _("Companies") }}
|
||||||
|
{% endif %}
|
||||||
|
</td>
|
||||||
|
<td>{{ doc.companies[0].company }}</td>
|
||||||
|
</tr>
|
||||||
|
{% for idx in range(1, doc.companies|length) %}
|
||||||
|
<tr>
|
||||||
|
<td>{{ doc.companies[idx].company }}</td>
|
||||||
|
</tr>
|
||||||
|
{% endfor %}
|
||||||
|
{% endif %}
|
||||||
|
</table>
|
||||||
|
|
||||||
|
{% if doc.disabled %}
|
||||||
|
<p>{{ _("The fiscal year has been automatically created in a Disabled state to maintain consistency with the previous fiscal year's status.") }}</p>
|
||||||
|
{% endif %}
|
||||||
|
|
||||||
|
<p>{{ _("Please review the {0} configuration and complete any required financial setup activities.").format(frappe.utils.get_link_to_form("Fiscal Year", doc.name, frappe.bold("Fiscal Year"))) }}</p>
|
||||||
@@ -1,7 +1,8 @@
|
|||||||
{
|
{
|
||||||
"attach_print": 0,
|
"attach_print": 0,
|
||||||
"channel": "Email",
|
"channel": "Email",
|
||||||
"condition": "doc.auto_created",
|
"condition": "doc.auto_created == 1",
|
||||||
|
"condition_type": "Python",
|
||||||
"creation": "2018-04-25 14:19:05.440361",
|
"creation": "2018-04-25 14:19:05.440361",
|
||||||
"days_in_advance": 0,
|
"days_in_advance": 0,
|
||||||
"docstatus": 0,
|
"docstatus": 0,
|
||||||
@@ -11,8 +12,15 @@
|
|||||||
"event": "New",
|
"event": "New",
|
||||||
"idx": 0,
|
"idx": 0,
|
||||||
"is_standard": 1,
|
"is_standard": 1,
|
||||||
|
<<<<<<< HEAD
|
||||||
"message": "<h3>{{_(\"Fiscal Year\")}}</h3>\n\n<p>{{ _(\"New fiscal year created :- \") }} {{ doc.name }}</p>",
|
"message": "<h3>{{_(\"Fiscal Year\")}}</h3>\n\n<p>{{ _(\"New fiscal year created :- \") }} {{ doc.name }}</p>",
|
||||||
"modified": "2018-04-25 14:30:38.588534",
|
"modified": "2018-04-25 14:30:38.588534",
|
||||||
|
=======
|
||||||
|
"message": "<h4>{{ _(\"New Fiscal Year - {0}\").format(doc.name) }}</h4>\n\n<p>{{ _(\"A new fiscal year has been automatically created.\") }}</p>\n\n<p>{{ _(\"Fiscal Year Details\") }}</p>\n\n<table style=\"margin-bottom: 1rem; width: 70%\">\n <tr>\n <td style=\"font-weight:bold; width: 40%\">{{ _(\"Year Name\") }}</td>\n <td>{{ doc.name }}</td>\n </tr>\n <tr>\n <td style=\"font-weight:bold; width: 40%\">{{ _(\"Start Date\") }}</td>\n <td>{{ frappe.format_value(doc.year_start_date) }}</td>\n </tr>\n <tr>\n <td style=\"font-weight:bold; width: 40%\">{{ _(\"End Date\") }}</td>\n <td>{{ frappe.format_value(doc.year_end_date) }}</td>\n </tr>\n {% if doc.companies|length > 0 %}\n <tr>\n <td style=\"vertical-align: top; font-weight: bold; width: 40%\" rowspan=\"{{ doc.companies|length }}\">\n {% if doc.companies|length < 2 %}\n {{ _(\"Company\") }}\n {% else %}\n {{ _(\"Companies\") }}\n {% endif %}\n </td>\n <td>{{ doc.companies[0].company }}</td>\n </tr>\n {% for idx in range(1, doc.companies|length) %}\n <tr>\n <td>{{ doc.companies[idx].company }}</td>\n </tr>\n {% endfor %}\n {% endif %}\n</table>\n\n{% if doc.disabled %}\n<p>{{ _(\"The fiscal year has been automatically created in a Disabled state to maintain consistency with the previous fiscal year's status.\") }}</p>\n{% endif %}\n\n<p>{{ _(\"Please review the {0} configuration and complete any required financial setup activities.\").format(frappe.utils.get_link_to_form(\"Fiscal Year\", doc.name, frappe.bold(\"Fiscal Year\"))) }}</p>",
|
||||||
|
"message_type": "HTML",
|
||||||
|
"minutes_offset": 0,
|
||||||
|
"modified": "2026-02-21 12:14:54.736795",
|
||||||
|
>>>>>>> 4c76786ce4 (fix(`fiscal_year`): `Fiscal Year` auto-generation and notification)
|
||||||
"modified_by": "Administrator",
|
"modified_by": "Administrator",
|
||||||
"module": "Accounts",
|
"module": "Accounts",
|
||||||
"name": "Notification for new fiscal year",
|
"name": "Notification for new fiscal year",
|
||||||
@@ -25,5 +33,12 @@
|
|||||||
"email_by_role": "Accounts Manager"
|
"email_by_role": "Accounts Manager"
|
||||||
}
|
}
|
||||||
],
|
],
|
||||||
|
<<<<<<< HEAD
|
||||||
"subject": "Notification for new fiscal year {{ doc.name }}"
|
"subject": "Notification for new fiscal year {{ doc.name }}"
|
||||||
}
|
}
|
||||||
|
=======
|
||||||
|
"send_system_notification": 0,
|
||||||
|
"send_to_all_assignees": 0,
|
||||||
|
"subject": "{{ _(\"New Fiscal Year {0} - Review Required\").format(doc.name) }}"
|
||||||
|
}
|
||||||
|
>>>>>>> 4c76786ce4 (fix(`fiscal_year`): `Fiscal Year` auto-generation and notification)
|
||||||
|
|||||||
Reference in New Issue
Block a user