From 8f6095d05f1d1d8f162e227ff4bdcd106601a09c Mon Sep 17 00:00:00 2001 From: barredterra <14891507+barredterra@users.noreply.github.com> Date: Mon, 19 Jan 2026 17:55:50 +0100 Subject: [PATCH] fix(accounts_controller): make return message translatable (cherry picked from commit 0209f0fe29cf8af6fb65877e4a8789dd85c53fee) # Conflicts: # erpnext/controllers/accounts_controller.py --- erpnext/controllers/accounts_controller.py | 13 ++++++------- 1 file changed, 6 insertions(+), 7 deletions(-) diff --git a/erpnext/controllers/accounts_controller.py b/erpnext/controllers/accounts_controller.py index 172c63bebf6..f6195e6e09e 100644 --- a/erpnext/controllers/accounts_controller.py +++ b/erpnext/controllers/accounts_controller.py @@ -184,9 +184,8 @@ class AccountsController(TransactionBase): msg = "" if self.get("update_outstanding_for_self"): - msg = ( - "We can see {0} is made against {1}. If you want {1}'s outstanding to be updated, " - "uncheck '{2}' checkbox.

Or" + msg = _( + "We can see {0} is made against {1}. If you want {1}'s outstanding to be updated, uncheck the '{2}' checkbox." ).format( frappe.bold(document_type), get_link_to_form(self.doctype, self.get("return_against")), @@ -197,8 +196,8 @@ class AccountsController(TransactionBase): abs(flt(self.rounded_total) or flt(self.grand_total)) > flt(against_voucher_outstanding) ): self.update_outstanding_for_self = 1 - msg = ( - "The outstanding amount {} in {} is lesser than {}. Updating the outstanding to this invoice.

And" + msg = _( + "The outstanding amount {0} in {1} is lesser than {2}. Updating the outstanding to this invoice." ).format( against_voucher_outstanding, get_link_to_form(self.doctype, self.get("return_against")), @@ -206,11 +205,11 @@ class AccountsController(TransactionBase): ) if msg: - msg += " you can use {} tool to reconcile against {} later.".format( + msg += "

" + _("You can use {0} to reconcile against {1} later.").format( get_link_to_form("Payment Reconciliation", "Payment Reconciliation"), get_link_to_form(self.doctype, self.get("return_against")), ) - frappe.msgprint(_(msg)) + frappe.msgprint(msg) def validate(self): if not self.get("is_return") and not self.get("is_debit_note"):