From c39e206fc7c7bebd7ce15b0b9b5ed4b4c4c194f6 Mon Sep 17 00:00:00 2001 From: Rohit Waghchaure Date: Tue, 23 Feb 2021 14:26:55 +0530 Subject: [PATCH] fix: incorrect serial no issue in the stock reco --- erpnext/stock/utils.py | 15 +++++++++++---- 1 file changed, 11 insertions(+), 4 deletions(-) diff --git a/erpnext/stock/utils.py b/erpnext/stock/utils.py index da4b529b01e..560165b532d 100644 --- a/erpnext/stock/utils.py +++ b/erpnext/stock/utils.py @@ -115,10 +115,17 @@ def get_serial_nos_data_after_transactions(args): order by posting_date, posting_time asc """, args, as_dict=1) for d in data: - if d.actual_qty > 0: - serial_nos.extend(get_serial_nos_data(d.serial_no)) - else: - serial_nos = list(set(serial_nos) - set(get_serial_nos_data(d.serial_no))) + for sn in get_serial_nos_data(d.serial_no): + if d.actual_qty > 0: + if sn not in serial_nos: + serial_nos.append(sn) + else: + serial_nos.remove(sn) + elif d.actual_qty < 0: + if sn in serial_nos: + serial_nos.remove(sn) + else: + serial_nos.append(sn) return '\n'.join(serial_nos)