From 90d82be966775a996d12331ec5edf57d5e0b2765 Mon Sep 17 00:00:00 2001 From: mbauskar Date: Thu, 30 Mar 2017 15:36:46 +0530 Subject: [PATCH] [minor] make varient fixes in item.js --- erpnext/stock/doctype/item/item.js | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/erpnext/stock/doctype/item/item.js b/erpnext/stock/doctype/item/item.js index 8327ea74970..3402619eac5 100644 --- a/erpnext/stock/doctype/item/item.js +++ b/erpnext/stock/doctype/item/item.js @@ -259,8 +259,6 @@ $.extend(erpnext.item, { }, make_variant: function(frm) { - var fields = [] - if(frm.doc.variant_based_on==="Item Attribute") { erpnext.item.show_modal_for_item_attribute_selection(frm); } else { @@ -299,6 +297,8 @@ $.extend(erpnext.item, { }, show_modal_for_item_attribute_selection: function(frm) { + var fields = [] + for(var i=0;i< frm.doc.attributes.length;i++){ var fieldtype, desc; var row = frm.doc.attributes[i];