CalvinBackup/erpnext
1
0
Fork 0
mirror of https://github.com/frappe/erpnext.git synced 2026-03-25 22:21:31 +01:00
Code Issues Packages Projects Releases Wiki Activity

fix: better implementation, handle missing purchase order

Browse Source 
(cherry picked from commit 66211dafd6)
This commit is contained in:
Ninad1306
2024-10-22 17:24:46 +05:30
committed by Mergify
parent 40927c7413
commit 41db040a60
1 changed files with 69 additions and 50 deletions
Download Patch File Download Diff File Expand all files Collapse all files

109
erpnext/subcontracting/doctype/subcontracting_receipt/subcontracting_receipt.py
View File

@@ -690,23 +690,47 @@ def make_purchase_receipt(source_name, target_doc=None, save=False, submit=False
if source_doc.is_return: if source_doc.is_return:
return return
po_doc = frappe.get_doc("Purchase Order", source_doc.items[0].purchase_order) po_sr_item_dict = {}
target_doc = get_mapped_doc( po_name = None
"Purchase Order", for item in source_doc.items:
po_doc.name, if not item.purchase_order:
{ continue
"Purchase Order": {
"doctype": "Purchase Receipt", if not po_name:
"validation": { po_name = item.purchase_order
"docstatus": ["=", 1],
}, po_sr_item_dict[item.purchase_order_item] = {
"field_no_map": ["items"], "qty": flt(item.qty),
}, "rejected_qty": flt(item.rejected_qty),
"Purchase Taxes and Charges": {"doctype": "Purchase Taxes and Charges", "reset_value": True}, "warehouse": item.warehouse,
}, "rejected_warehouse": item.rejected_warehouse,
"subcontracting_receipt_item": item.name,
}
if not po_name:
frappe.throw(
_("Purchase Order Item reference is missing in Subcontracting Receipt {0}").format(
source_doc.name
)
) )
target_doc.update( def update_item(obj, target, source_parent):
sr_item_details = po_sr_item_dict.get(obj.name)
ratio = flt(obj.qty) / flt(obj.fg_item_qty)
target.update(
{
"qty": ratio * sr_item_details["qty"],
"rejected_qty": ratio * sr_item_details["rejected_qty"],
"warehouse": sr_item_details["warehouse"],
"rejected_warehouse": sr_item_details["rejected_warehouse"],
"subcontracting_receipt_item": sr_item_details["subcontracting_receipt_item"],
}
)
def post_process(source, target):
target.set_missing_values()
target.update(
{ {
"posting_date": source_doc.posting_date, "posting_date": source_doc.posting_date,
"posting_time": source_doc.posting_time, "posting_time": source_doc.posting_time,
@@ -714,40 +738,35 @@ def make_purchase_receipt(source_name, target_doc=None, save=False, submit=False
"supplier_warehouse": source_doc.supplier_warehouse, "supplier_warehouse": source_doc.supplier_warehouse,
"is_subcontracted": 1, "is_subcontracted": 1,
"is_old_subcontracting_flow": 0, "is_old_subcontracting_flow": 0,
"currency": frappe.get_cached_value("Company", target_doc.company, "default_currency"), "currency": frappe.get_cached_value("Company", target.company, "default_currency"),
} }
) )
po_items_details = {po_item.name: po_item for po_item in po_doc.items} target_doc = get_mapped_doc(
"Purchase Order",
for item in source_doc.items: po_name,
if po_item := po_items_details.get(item.purchase_order_item): {
conversion_factor = flt(po_item.qty) / flt(po_item.fg_item_qty) "Purchase Order": {
item_row = { "doctype": "Purchase Receipt",
"item_code": po_item.item_code, "field_map": {"supplier_warehouse": "supplier_warehouse"},
"item_name": po_item.item_name, "validation": {
"conversion_factor": conversion_factor, "docstatus": ["=", 1],
"qty": flt(item.qty) * conversion_factor, },
"rejected_qty": flt(item.rejected_qty) * conversion_factor, },
"uom": po_item.uom, "Purchase Order Item": {
"rate": po_item.rate, "doctype": "Purchase Receipt Item",
"warehouse": item.warehouse, "field_map": {
"rejected_warehouse": item.rejected_warehouse, "name": "purchase_order_item",
"purchase_order": po_doc.name, "parent": "purchase_order",
"purchase_order_item": item.purchase_order_item, "bom": "bom",
"subcontracting_receipt_item": item.name, },
"project": po_item.project, "postprocess": update_item,
} "condition": lambda doc: doc.name in po_sr_item_dict,
target_doc.append("items", item_row) },
"Purchase Taxes and Charges": {"doctype": "Purchase Taxes and Charges", "reset_value": True},
if not target_doc.items: },
frappe.throw( postprocess=post_process,
_("Purchase Order Item reference is missing in Subcontracting Receipt {0}").format(
source_doc.name
) )
)
target_doc.set_missing_values()
if (save or submit) and frappe.has_permission(target_doc.doctype, "create"): if (save or submit) and frappe.has_permission(target_doc.doctype, "create"):
target_doc.save() target_doc.save()