From 438e0f5d4986660bc50663298c0bd8acbfd2b7cb Mon Sep 17 00:00:00 2001 From: rohitwaghchaure Date: Fri, 1 May 2020 10:50:02 +0530 Subject: [PATCH] fix: 'NoneType' object is not iterable (#21538) --- erpnext/stock/get_item_details.py | 10 ++++++++-- 1 file changed, 8 insertions(+), 2 deletions(-) diff --git a/erpnext/stock/get_item_details.py b/erpnext/stock/get_item_details.py index 51f27fd3e78..f43592bef63 100644 --- a/erpnext/stock/get_item_details.py +++ b/erpnext/stock/get_item_details.py @@ -340,8 +340,14 @@ def get_basic_details(args, item, overwrite_warehouse=True): out["manufacturer_part_no"] = None out["manufacturer"] = None else: - out["manufacturer"], out["manufacturer_part_no"] = frappe.get_value("Item", item.name, - ["default_item_manufacturer", "default_manufacturer_part_no"] ) + data = frappe.get_value("Item", item.name, + ["default_item_manufacturer", "default_manufacturer_part_no"] , as_dict=1) + + if data: + out.update({ + "manufacturer": data.default_item_manufacturer, + "manufacturer_part_no": data.default_manufacturer_part_no + }) child_doctype = args.doctype + ' Item' meta = frappe.get_meta(child_doctype)