From 464fc1f087d800fc1fff796638bcd386144fc6eb Mon Sep 17 00:00:00 2001 From: Saqib Ansari Date: Thu, 5 Nov 2020 10:49:21 +0530 Subject: [PATCH] chore: error logging --- erpnext/regional/india/e_invoice/utils.py | 28 ++++++++++++++--------- 1 file changed, 17 insertions(+), 11 deletions(-) diff --git a/erpnext/regional/india/e_invoice/utils.py b/erpnext/regional/india/e_invoice/utils.py index 168ee38587f..bda0cd8ef5c 100644 --- a/erpnext/regional/india/e_invoice/utils.py +++ b/erpnext/regional/india/e_invoice/utils.py @@ -237,8 +237,8 @@ def make_einvoice(doctype, name): item_list = get_item_list(invoice) doc_details = get_doc_details(invoice) value_details = get_value_details(invoice) - trans_details = get_trans_details(invoice) seller_details = get_party_details(invoice.company_address) + seller_details.update({ 'pincode': 193502 }) if invoice.gst_category == 'Overseas': buyer_details = get_overseas_address_details(invoice.customer_address) @@ -496,15 +496,15 @@ class GSPConnector(): docname = args.docname eway_bill_details = get_eway_bill_details(args) data = json.dumps({ - "Irn": args.irn, - "Distance": cint(eway_bill_details.distance), - "TransMode": eway_bill_details.mode_of_transport, - "TransId": eway_bill_details.gstin, - "TransName": eway_bill_details.transporter, - "TrnDocDt": eway_bill_details.document_date, - "TrnDocNo": eway_bill_details.document_name, - "VehNo": eway_bill_details.vehicle_no, - "VehType": eway_bill_details.vehicle_type + 'Irn': args.irn, + 'Distance': cint(eway_bill_details.distance), + 'TransMode': eway_bill_details.mode_of_transport, + 'TransId': eway_bill_details.gstin, + 'TransName': eway_bill_details.transporter, + 'TrnDocDt': eway_bill_details.document_date, + 'TrnDocNo': eway_bill_details.document_name, + 'VehNo': eway_bill_details.vehicle_no, + 'VehType': eway_bill_details.vehicle_type }) try: @@ -544,7 +544,13 @@ class GSPConnector(): self.log_error(e) def log_error(self, exc): - print(exc) + message = "\n".join(["Data:", json.dumps(exc), "--" * 50, "\nException:", traceback.format_exc()]) + frappe.log_error(title="E Invoicing Error", message=message) + link_to_error_list = '{1}'.format('Error Log', 'Error Log') + frappe.throw( + _('An error occurred while making API request. Please check {} for more information.').format(link_to_error_list), + title=_('E Invoice Request Failed') + ) @frappe.whitelist() def generate_irn(docname):