From 4b8ed0f6aeec314bb87784f9b7ccbdd65456e637 Mon Sep 17 00:00:00 2001
From: Rucha Mahabal <ruchamahabal2@gmail.com>
Date: Fri, 17 Nov 2023 13:46:46 +0530
Subject: [PATCH] fix: use `get_all` instead of `get_list`

- query report already filters records based on permissions for link fields

- allow employees access to leave balance report by default
---
 .../employee_leave_balance.json               | 40 +++++++++++--------
 .../employee_leave_balance.py                 |  8 ++--
 2 files changed, 27 insertions(+), 21 deletions(-)

diff --git a/erpnext/hr/report/employee_leave_balance/employee_leave_balance.json b/erpnext/hr/report/employee_leave_balance/employee_leave_balance.json
index 8b47f7e842d..577f6a7b70e 100644
--- a/erpnext/hr/report/employee_leave_balance/employee_leave_balance.json
+++ b/erpnext/hr/report/employee_leave_balance/employee_leave_balance.json
@@ -1,26 +1,32 @@
 {
- "add_total_row": 0, 
- "apply_user_permissions": 1, 
- "creation": "2013-02-22 15:29:34", 
- "disabled": 0, 
- "docstatus": 0, 
- "doctype": "Report", 
- "idx": 3, 
- "is_standard": "Yes", 
- "modified": "2017-02-24 20:18:04.317397", 
- "modified_by": "Administrator", 
- "module": "HR", 
- "name": "Employee Leave Balance", 
- "owner": "Administrator", 
- "ref_doctype": "Employee", 
- "report_name": "Employee Leave Balance", 
- "report_type": "Script Report", 
+ "add_total_row": 0,
+ "columns": [],
+ "creation": "2013-02-22 15:29:34",
+ "disabled": 0,
+ "docstatus": 0,
+ "doctype": "Report",
+ "filters": [],
+ "idx": 3,
+ "is_standard": "Yes",
+ "letterhead": null,
+ "modified": "2023-11-17 13:28:40.669200",
+ "modified_by": "Administrator",
+ "module": "HR",
+ "name": "Employee Leave Balance",
+ "owner": "Administrator",
+ "prepared_report": 0,
+ "ref_doctype": "Employee",
+ "report_name": "Employee Leave Balance",
+ "report_type": "Script Report",
  "roles": [
   {
    "role": "HR User"
-  }, 
+  },
   {
    "role": "HR Manager"
+  },
+  {
+   "role": "Employee"
   }
  ]
 }
\ No newline at end of file
diff --git a/erpnext/hr/report/employee_leave_balance/employee_leave_balance.py b/erpnext/hr/report/employee_leave_balance/employee_leave_balance.py
index 192b255f3e0..fb1d8e2875d 100644
--- a/erpnext/hr/report/employee_leave_balance/employee_leave_balance.py
+++ b/erpnext/hr/report/employee_leave_balance/employee_leave_balance.py
@@ -85,19 +85,19 @@ def get_columns() -> List[Dict]:
 
 
 def get_data(filters: Filters) -> List:
-	leave_types = frappe.db.get_list("Leave Type", pluck="name", order_by="name")
+	leave_types = frappe.get_all("Leave Type", pluck="name", order_by="name")
 	conditions = get_conditions(filters)
 
 	user = frappe.session.user
 	department_approver_map = get_department_leave_approver_map(filters.department)
 
-	active_employees = frappe.get_list(
+	active_employees = frappe.get_all(
 		"Employee",
 		filters=conditions,
 		fields=["name", "employee_name", "department", "user_id", "leave_approver"],
 	)
 
-	precision = cint(frappe.db.get_single_value("System Settings", "float_precision", cache=True))
+	precision = cint(frappe.db.get_single_value("System Settings", "float_precision"))
 	consolidate_leave_types = len(active_employees) > 1 and filters.consolidate_leave_types
 	row = None
 
@@ -188,7 +188,7 @@ def get_conditions(filters: Filters) -> Dict:
 
 def get_department_leave_approver_map(department: Optional[str] = None):
 	# get current department and all its child
-	department_list = frappe.get_list(
+	department_list = frappe.get_all(
 		"Department",
 		filters={"disabled": 0},
 		or_filters={"name": department, "parent_department": department},