diff --git a/erpnext/accounts/doctype/purchase_invoice/purchase_invoice.py b/erpnext/accounts/doctype/purchase_invoice/purchase_invoice.py index d4a5fa179b4..2e349803529 100644 --- a/erpnext/accounts/doctype/purchase_invoice/purchase_invoice.py +++ b/erpnext/accounts/doctype/purchase_invoice/purchase_invoice.py @@ -76,7 +76,7 @@ class PurchaseInvoice(BuyingController): def get_advances(self): if not self.is_return: super(PurchaseInvoice, self).get_advances(self.credit_to, "Supplier", self.supplier, - "Purchase Invoice Advance", "advances", "debit", "purchase_order") + "Purchase Invoice Advance", "advances", "debit_in_account_currency", "purchase_order") def check_active_purchase_items(self): for d in self.get('items'): diff --git a/erpnext/accounts/doctype/sales_invoice/sales_invoice.py b/erpnext/accounts/doctype/sales_invoice/sales_invoice.py index 940f7542628..a349e2fe4b8 100644 --- a/erpnext/accounts/doctype/sales_invoice/sales_invoice.py +++ b/erpnext/accounts/doctype/sales_invoice/sales_invoice.py @@ -256,7 +256,7 @@ class SalesInvoice(SellingController): def get_advances(self): if not self.is_return: super(SalesInvoice, self).get_advances(self.debit_to, "Customer", self.customer, - "Sales Invoice Advance", "advances", "credit", "sales_order") + "Sales Invoice Advance", "advances", "credit_in_account_currency", "sales_order") def get_company_abbr(self): return frappe.db.sql("select abbr from tabCompany where name=%s", self.company)[0][0] diff --git a/erpnext/accounts/party.py b/erpnext/accounts/party.py index 381e4d44ae0..516608ff0ee 100644 --- a/erpnext/accounts/party.py +++ b/erpnext/accounts/party.py @@ -217,10 +217,16 @@ def validate_party_accounts(doc): for account in doc.get("accounts"): if account.company in companies: - frappe.throw(_("There can only be 1 Account per Company in {0} {1}").format(doc.doctype, doc.name), - DuplicatePartyAccountError) + frappe.throw(_("There can only be 1 Account per Company in {0} {1}") + .format(doc.doctype, doc.name), DuplicatePartyAccountError) else: companies.append(account.company) + + party_account_currency = frappe.db.get_value("Account", account.account, "account_currency") + existing_gle_currency = get_party_gle_currency(doc.doctype, doc.name, account.company) + + if existing_gle_currency and party_account_currency != existing_gle_currency: + frappe.throw(_("Accounting entries have already been made in currency {0} for company {1}. Please select a receivable or payable account with currency {0}.").format(existing_gle_currency, account.company)) @frappe.whitelist() def get_due_date(posting_date, party_type, party, company): diff --git a/erpnext/accounts/utils.py b/erpnext/accounts/utils.py index ffb8a4c3dcb..88b1ed4c6c0 100644 --- a/erpnext/accounts/utils.py +++ b/erpnext/accounts/utils.py @@ -211,7 +211,8 @@ def update_against_doc(d, jv_obj): if d['allocated_amt'] < d['unadjusted_amt']: jvd = frappe.db.sql(""" - select cost_center, balance, against_account, is_advance, account_type, exchange_rate + select cost_center, balance, against_account, is_advance, + account_type, exchange_rate, account_currency from `tabJournal Entry Account` where name = %s """, d['voucher_detail_no'], as_dict=True) @@ -222,6 +223,7 @@ def update_against_doc(d, jv_obj): ch = jv_obj.append("accounts") ch.account = d['account'] ch.account_type = jvd[0]['account_type'] + ch.account_currency = jvd[0]['account_currency'] ch.exchange_rate = jvd[0]['exchange_rate'] ch.party_type = d["party_type"] ch.party = d["party"] diff --git a/erpnext/public/js/controllers/transaction.js b/erpnext/public/js/controllers/transaction.js index 7f2cee760a9..08d4f32b681 100644 --- a/erpnext/public/js/controllers/transaction.js +++ b/erpnext/public/js/controllers/transaction.js @@ -495,7 +495,8 @@ erpnext.TransactionController = erpnext.taxes_and_totals.extend({ } if(this.frm.fields_dict["advances"]) { - setup_field_label_map(["advance_amount", "allocated_amount"], company_currency, "advances"); + setup_field_label_map(["advance_amount", "allocated_amount"], + this.frm.doc.party_account_currency, "advances"); } // toggle columns