From 37a55345fdaebb2266be6fe85eb42c62ad07759e Mon Sep 17 00:00:00 2001
From: Shivam Mishra <scm.mymail@gmail.com>
Date: Thu, 25 Apr 2019 19:29:56 +0530
Subject: [PATCH 1/3] feat: removed home page for lms role

---
 erpnext/hooks.py | 4 ----
 1 file changed, 4 deletions(-)

diff --git a/erpnext/hooks.py b/erpnext/hooks.py
index ecc961186ad..47d205692c2 100644
--- a/erpnext/hooks.py
+++ b/erpnext/hooks.py
@@ -169,10 +169,6 @@ default_roles = [
 	{'role': 'Student', 'doctype':'Student', 'email_field': 'student_email_id'},
 ]
 
-role_home_page = {
-	"LMS User": "/lms"
-}
-
 has_website_permission = {
 	"Sales Order": "erpnext.controllers.website_list_for_contact.has_website_permission",
 	"Quotation": "erpnext.controllers.website_list_for_contact.has_website_permission",

From 2428485ebb5a866a4a3283d17284b1b320c27984 Mon Sep 17 00:00:00 2001
From: Shivam Mishra <scm.mymail@gmail.com>
Date: Thu, 25 Apr 2019 19:33:22 +0530
Subject: [PATCH 2/3] fix (ui): Card layout

---
 erpnext/public/js/education/lms/components/CourseCard.vue   | 2 +-
 erpnext/public/js/education/lms/components/ProgramCard.vue  | 2 +-
 erpnext/public/js/education/lms/components/ProgressCard.vue | 2 +-
 erpnext/public/js/education/lms/components/ScoreCard.vue    | 2 +-
 erpnext/public/js/education/lms/components/TopicCard.vue    | 2 +-
 5 files changed, 5 insertions(+), 5 deletions(-)

diff --git a/erpnext/public/js/education/lms/components/CourseCard.vue b/erpnext/public/js/education/lms/components/CourseCard.vue
index 223654f27e8..16f8873bd1b 100644
--- a/erpnext/public/js/education/lms/components/CourseCard.vue
+++ b/erpnext/public/js/education/lms/components/CourseCard.vue
@@ -1,5 +1,5 @@
 <template>
-    <div class="mt-3 col-md-4 col-sm-12">
+    <div class="py-3 col-md-4 col-sm-12">
         <div class="card h-100">
             <div class="card-hero-img" v-if="course.hero_image" v-bind:style="{ 'background-image': 'url(' + image + ')' }"></div>
             <div v-else class="card-image-wrapper">
diff --git a/erpnext/public/js/education/lms/components/ProgramCard.vue b/erpnext/public/js/education/lms/components/ProgramCard.vue
index 26d3882721f..20de085e6f3 100644
--- a/erpnext/public/js/education/lms/components/ProgramCard.vue
+++ b/erpnext/public/js/education/lms/components/ProgramCard.vue
@@ -1,5 +1,5 @@
 <template>
-<div class='mt-3 col-md-4 col-sm-12'>
+<div class='py-3 col-md-4 col-sm-12'>
     <div class="card h-100">
         <router-link :to="'/Program/' + program.name">
             <div class="card-hero-img" v-if="program.hero_image" v-bind:style="{ 'background-image': 'url(' + image + ')' }"></div>
diff --git a/erpnext/public/js/education/lms/components/ProgressCard.vue b/erpnext/public/js/education/lms/components/ProgressCard.vue
index 77fb6ef5c1d..66b61f694e4 100644
--- a/erpnext/public/js/education/lms/components/ProgressCard.vue
+++ b/erpnext/public/js/education/lms/components/ProgressCard.vue
@@ -1,5 +1,5 @@
 <template>
-    <div class='mt-3 col-md-4 col-sm-12'>
+    <div class='py-3 col-md-4 col-sm-12'>
         <div class="card h-100">
             <div class='card-body'>
                 <router-link :to="'/Program/' + programData.name">
diff --git a/erpnext/public/js/education/lms/components/ScoreCard.vue b/erpnext/public/js/education/lms/components/ScoreCard.vue
index 1cf53ef54ea..80b12cb6f63 100644
--- a/erpnext/public/js/education/lms/components/ScoreCard.vue
+++ b/erpnext/public/js/education/lms/components/ScoreCard.vue
@@ -1,5 +1,5 @@
 <template>
-    <div v-if="quizData" class='mt-3 col-md-4 col-sm-12'>
+    <div v-if="quizData" class='py-3 col-md-4 col-sm-12'>
         <div class="card h-100">
             <div class='card-body'>
                 <h5 class='card-title'>{{ quizData.program }}</h5>
diff --git a/erpnext/public/js/education/lms/components/TopicCard.vue b/erpnext/public/js/education/lms/components/TopicCard.vue
index 3e930df07b0..4cb8e85c3bf 100644
--- a/erpnext/public/js/education/lms/components/TopicCard.vue
+++ b/erpnext/public/js/education/lms/components/TopicCard.vue
@@ -1,6 +1,6 @@
 
 <template>
-    <div class="mt-3 col-md-4 col-sm-12">
+    <div class="py-3 col-md-4 col-sm-12">
         <div class="card h-100">
             <div class="card-hero-img" v-if="topic.hero_image" v-bind:style="{ 'background-image': 'url(' + image + ')' }"></div>
             <div v-else class="card-image-wrapper">

From 9fe7257bfc93ca0acef053d2918decc608d20e28 Mon Sep 17 00:00:00 2001
From: Shivam Mishra <scm.mymail@gmail.com>
Date: Thu, 25 Apr 2019 19:44:37 +0530
Subject: [PATCH 3/3] fix (ui): refactored breadcrumbs

---
 .../js/education/lms/components/Breadcrumb.vue      | 13 ++++++++++---
 1 file changed, 10 insertions(+), 3 deletions(-)

diff --git a/erpnext/public/js/education/lms/components/Breadcrumb.vue b/erpnext/public/js/education/lms/components/Breadcrumb.vue
index e7c0fc34bb2..1b617a3751c 100644
--- a/erpnext/public/js/education/lms/components/Breadcrumb.vue
+++ b/erpnext/public/js/education/lms/components/Breadcrumb.vue
@@ -1,8 +1,15 @@
 <template>
 	<div>
-		<span v-for="(route, index) in routeData">
-			<router-link :to="route.route">{{ route.label }}</router-link><span> / </span>
-		</span>
+		<nav aria-label="breadcrumb">
+			<ol class="breadcrumb">
+				<li v-for="(route, index) in routeData" class="breadcrumb-item active" aria-current="page">
+					<router-link v-if="index != routeData.length - 1" :to="route.route">
+						{{ route.label }}
+					</router-link>
+					<span v-else>{{ route.label }}</span>
+				</li>
+			</ol>
+		</nav>
 	</div>
 </template>
 <script type="text/javascript">