From 5688a6c31afbf24e694169b2ef9dca8ebb78405f Mon Sep 17 00:00:00 2001 From: Rushabh Mehta Date: Fri, 3 Jul 2015 11:34:53 +0530 Subject: [PATCH] [fix] remove user permission if user id is unset #3447 --- erpnext/hr/doctype/employee/employee.py | 4 ++++ 1 file changed, 4 insertions(+) diff --git a/erpnext/hr/doctype/employee/employee.py b/erpnext/hr/doctype/employee/employee.py index cb0ce118b31..a2bb10cc69d 100644 --- a/erpnext/hr/doctype/employee/employee.py +++ b/erpnext/hr/doctype/employee/employee.py @@ -45,6 +45,10 @@ class Employee(Document): if self.user_id: self.validate_for_enabled_user_id() self.validate_duplicate_user_id() + else: + existing_user_id = frappe.db.get_value("Employee", self.name, "user_id") + if existing_user_id: + frappe.permissions.remove_user_permission("Employee", self.name, existing_user_id) def on_update(self): if self.user_id: