From 5db7888a8d8688d40dc796d8b4b3f4f814e99e61 Mon Sep 17 00:00:00 2001
From: ruthra kumar <ruthra@erpnext.com>
Date: Mon, 20 Oct 2025 13:16:18 +0530
Subject: [PATCH] refactor: enable legacy controller by default for pcv

(cherry picked from commit fe39ce03bbb2b6419452ced07aad510b861dfa69)

# Conflicts:
#	erpnext/accounts/doctype/accounts_settings/accounts_settings.json
#	erpnext/accounts/doctype/period_closing_voucher/test_period_closing_voucher.py
---
 .../doctype/accounts_settings/accounts_settings.json     | 6 +++++-
 .../test_period_closing_voucher.py                       | 8 ++++++++
 erpnext/patches.txt                                      | 1 +
 .../v15_0/toggle_legacy_controller_for_period_closing.py | 9 +++++++++
 4 files changed, 23 insertions(+), 1 deletion(-)
 create mode 100644 erpnext/patches/v15_0/toggle_legacy_controller_for_period_closing.py

diff --git a/erpnext/accounts/doctype/accounts_settings/accounts_settings.json b/erpnext/accounts/doctype/accounts_settings/accounts_settings.json
index dad7165b665..6a640d3464c 100644
--- a/erpnext/accounts/doctype/accounts_settings/accounts_settings.json
+++ b/erpnext/accounts/doctype/accounts_settings/accounts_settings.json
@@ -640,7 +640,7 @@
    "label": "Use Legacy Budget Controller"
   },
   {
-   "default": "0",
+   "default": "1",
    "fieldname": "use_legacy_controller_for_pcv",
    "fieldtype": "Check",
    "label": "Use Legacy Controller For Period Closing Voucher"
@@ -652,11 +652,15 @@
  "index_web_pages_for_search": 1,
  "issingle": 1,
  "links": [],
+<<<<<<< HEAD
 <<<<<<< HEAD
  "modified": "2025-07-18 13:56:47.192437",
 =======
  "modified": "2025-10-01 15:17:47.168354",
 >>>>>>> 4888461be2 (refactor: checkbox for pcv controller)
+=======
+ "modified": "2025-10-20 14:06:08.870427",
+>>>>>>> fe39ce03bb (refactor: enable legacy controller by default for pcv)
  "modified_by": "Administrator",
  "module": "Accounts",
  "name": "Accounts Settings",
diff --git a/erpnext/accounts/doctype/period_closing_voucher/test_period_closing_voucher.py b/erpnext/accounts/doctype/period_closing_voucher/test_period_closing_voucher.py
index 34e2fdd9082..809e447aef4 100644
--- a/erpnext/accounts/doctype/period_closing_voucher/test_period_closing_voucher.py
+++ b/erpnext/accounts/doctype/period_closing_voucher/test_period_closing_voucher.py
@@ -13,7 +13,15 @@ from erpnext.accounts.doctype.sales_invoice.test_sales_invoice import create_sal
 from erpnext.accounts.utils import get_fiscal_year
 
 
+<<<<<<< HEAD
 class TestPeriodClosingVoucher(unittest.TestCase):
+=======
+class TestPeriodClosingVoucher(IntegrationTestCase):
+	def setUp(self):
+		super().setUp()
+		frappe.db.set_single_value("Accounts Settings", "use_legacy_controller_for_pcv", 1)
+
+>>>>>>> fe39ce03bb (refactor: enable legacy controller by default for pcv)
 	def test_closing_entry(self):
 		frappe.db.sql("delete from `tabGL Entry` where company='Test PCV Company'")
 		frappe.db.sql("delete from `tabPeriod Closing Voucher` where company='Test PCV Company'")
diff --git a/erpnext/patches.txt b/erpnext/patches.txt
index 4e05b974d16..bb3d5f07ef8 100644
--- a/erpnext/patches.txt
+++ b/erpnext/patches.txt
@@ -423,3 +423,4 @@ erpnext.patches.v15_0.add_company_payment_gateway_account
 erpnext.patches.v15_0.update_uae_zero_rated_fetch
 erpnext.patches.v15_0.update_fieldname_in_accounting_dimension_filter
 erpnext.patches.v15_0.set_asset_status_if_not_already_set
+erpnext.patches.v15_0.toggle_legacy_controller_for_period_closing
diff --git a/erpnext/patches/v15_0/toggle_legacy_controller_for_period_closing.py b/erpnext/patches/v15_0/toggle_legacy_controller_for_period_closing.py
new file mode 100644
index 00000000000..7e7cb2f7b49
--- /dev/null
+++ b/erpnext/patches/v15_0/toggle_legacy_controller_for_period_closing.py
@@ -0,0 +1,9 @@
+import frappe
+
+
+def execute():
+	"""
+	Description:
+	Enable Legacy controller for Period Closing Voucher
+	"""
+	frappe.db.set_single_value("Accounts Settings", "use_legacy_controller_for_pcv", 1)