From 5f82db200e91bf703dfbaf5cb07e0325c6c2239e Mon Sep 17 00:00:00 2001 From: diptanilsaha Date: Tue, 3 Mar 2026 14:08:49 +0530 Subject: [PATCH] fix(pricing_rule): strict validation of `transaction_type` (cherry picked from commit 7ec0354a79176f858aff3d99dce1c5a06b2cf77d) --- erpnext/accounts/doctype/pricing_rule/pricing_rule.py | 5 ++--- 1 file changed, 2 insertions(+), 3 deletions(-) diff --git a/erpnext/accounts/doctype/pricing_rule/pricing_rule.py b/erpnext/accounts/doctype/pricing_rule/pricing_rule.py index 14ec325bea2..6a58ae17059 100644 --- a/erpnext/accounts/doctype/pricing_rule/pricing_rule.py +++ b/erpnext/accounts/doctype/pricing_rule/pricing_rule.py @@ -346,8 +346,7 @@ def apply_pricing_rule(args, doc=None): args = frappe._dict(args) - if not args.transaction_type: - set_transaction_type(args) + set_transaction_type(args) # list of dictionaries out = [] @@ -684,7 +683,7 @@ def remove_pricing_rules(item_list): def set_transaction_type(args): - if args.transaction_type: + if args.transaction_type in ["buying", "selling"]: return if args.doctype in ("Opportunity", "Quotation", "Sales Order", "Delivery Note", "Sales Invoice"): args.transaction_type = "selling"