From 65c8466622c69a64bb904aa7cd1059c61949c3e0 Mon Sep 17 00:00:00 2001 From: Manas Solanki Date: Fri, 5 May 2017 17:28:09 +0530 Subject: [PATCH] check for mandatory field before frappe.call (#8705) --- erpnext/schools/doctype/student_group/student_group.js | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/erpnext/schools/doctype/student_group/student_group.js b/erpnext/schools/doctype/student_group/student_group.js index c2c6912ba07..ed9469015b3 100644 --- a/erpnext/schools/doctype/student_group/student_group.js +++ b/erpnext/schools/doctype/student_group/student_group.js @@ -42,7 +42,7 @@ frappe.ui.form.on("Student Group", { }, get_students: function(frm) { - if (frm.doc.group_based_on != "Activity") { + if (frm.doc.group_based_on == "Batch" || frm.doc.group_based_on == "Course") { var student_list = []; var max_roll_no = 0; $.each(frm.doc.students, function(i,d) {