CalvinBackup/erpnext
1
0
Fork 0
mirror of https://github.com/frappe/erpnext.git synced 2026-03-06 03:52:15 +00:00
Code Issues Packages Projects Releases Wiki Activity

fix: bug with comparison regarding None values and empty string

Browse Source 
In their default state, the fields can be `None`. When a user enters something and deletes it afterwards, the fields contain an empty string.

This fixes the comparison.

(cherry picked from commit 3fd5a0f100)
This commit is contained in:
Markus Lobedann
2026-02-17 12:46:30 +01:00
committed by Mergify
parent 10be8f19e2
commit 66d1b7c837
1 changed files with 3 additions and 1 deletions
Download Patch File Download Diff File Expand all files Collapse all files

4
erpnext/stock/doctype/quality_inspection/quality_inspection.py
View File

@@ -278,7 +278,9 @@ class QualityInspection(Document):
def set_status_based_on_acceptance_values(self, reading): def set_status_based_on_acceptance_values(self, reading):
if not cint(reading.numeric): if not cint(reading.numeric):
result = reading.get("reading_value") == reading.get("value") reading_value = reading.get("reading_value") or ""
value = reading.get("value") or ""
result = reading_value == value
else: else:
# numeric readings # numeric readings
result = self.min_max_criteria_passed(reading) result = self.min_max_criteria_passed(reading)