From 689130cf9b175ce8cc15663e429096741e6dd210 Mon Sep 17 00:00:00 2001 From: Rushabh Mehta Date: Mon, 27 Jun 2016 17:09:59 +0530 Subject: [PATCH] [minor] fix holiday_list validation --- erpnext/hr/doctype/holiday_list/holiday_list.py | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/erpnext/hr/doctype/holiday_list/holiday_list.py b/erpnext/hr/doctype/holiday_list/holiday_list.py index 0412624d391..893568977b8 100644 --- a/erpnext/hr/doctype/holiday_list/holiday_list.py +++ b/erpnext/hr/doctype/holiday_list/holiday_list.py @@ -34,7 +34,7 @@ class HolidayList(Document): throw(_("To Date cannot be before From Date")) for day in self.get("holidays"): - if not (self.from_date <= day.holiday_date <= self.to_date): + if not (getdate(self.from_date) <= getdate(day.holiday_date) <= getdate(self.to_date)): frappe.throw(_("The holiday on {0} is not between From Date and To Date").format(formatdate(day.holiday_date))) def get_weekly_off_date_list(self, start_date, end_date):