From 68a39dfa331d7f2922f7961a243d303015e90008 Mon Sep 17 00:00:00 2001 From: "mergify[bot]" <37929162+mergify[bot]@users.noreply.github.com> Date: Tue, 9 Jul 2024 12:19:10 +0530 Subject: [PATCH] fix: BOM Creator Recursion Error on duplicate save (backport #41622) (#42179) fix: BOM Creator Recursion Error on duplicate save (#41622) (cherry picked from commit 9cfe09bdf60a30366e0608fe0f66fdfdad214129) Co-authored-by: Richard Case <110036763+casesolved-co-uk@users.noreply.github.com> --- .../manufacturing/doctype/bom_creator/bom_creator.py | 10 +++++----- 1 file changed, 5 insertions(+), 5 deletions(-) diff --git a/erpnext/manufacturing/doctype/bom_creator/bom_creator.py b/erpnext/manufacturing/doctype/bom_creator/bom_creator.py index e236e7a6345..71b23ba3202 100644 --- a/erpnext/manufacturing/doctype/bom_creator/bom_creator.py +++ b/erpnext/manufacturing/doctype/bom_creator/bom_creator.py @@ -156,12 +156,12 @@ class BOMCreator(Document): amount = self.get_raw_material_cost() self.raw_material_cost = amount - def get_raw_material_cost(self, fg_reference_id=None, amount=0): - if not fg_reference_id: - fg_reference_id = self.name + def get_raw_material_cost(self, fg_item=None, amount=0): + if not fg_item: + fg_item = self.item_code for row in self.items: - if row.fg_reference_id != fg_reference_id: + if row.fg_item != fg_item: continue if not row.is_expandable: @@ -183,7 +183,7 @@ class BOMCreator(Document): else: row.amount = 0.0 - row.amount = self.get_raw_material_cost(row.name, row.amount) + row.amount = self.get_raw_material_cost(row.item_code, row.amount) row.rate = flt(row.amount) / (flt(row.qty) * flt(row.conversion_factor)) amount += flt(row.amount)