CalvinBackup/erpnext
1
0
Fork 0
mirror of https://github.com/frappe/erpnext.git synced 2026-03-24 05:32:46 +01:00
Code Issues Packages Projects Releases Wiki Activity

feat(UX): scroll to required field (backport #44367) (#45433)

Browse Source 
feat(UX): scroll to required field (#44367)

(cherry picked from commit 4008ca5ddd)

Co-authored-by: Raffael Meyer <14891507+barredterra@users.noreply.github.com>
This commit is contained in:
mergify[bot]
2025-01-26 12:14:44 +05:30
committed by GitHub
parent f3b8d6867b
commit 692a44816f
1 changed files with 40 additions and 18 deletions
Download Patch File Download Diff File Expand all files Collapse all files

58
erpnext/public/js/queries.js
View File

@@ -28,9 +28,13 @@ $.extend(erpnext.queries, {
customer_filter: function (doc) { customer_filter: function (doc) {
if (!doc.customer) { if (!doc.customer) {
frappe.throw( cur_frm.scroll_to_field("customer");
__("Please set {0}", [__(frappe.meta.get_label(doc.doctype, "customer", doc.name))]) frappe.show_alert({
); message: __("Please set {0} first.", [
__(frappe.meta.get_label(doc.doctype, "customer", doc.name)),
]),
indicator: "orange",
});
} }
return { filters: { customer: doc.customer } }; return { filters: { customer: doc.customer } };
@@ -39,11 +43,13 @@ $.extend(erpnext.queries, {
contact_query: function (doc) { contact_query: function (doc) {
if (frappe.dynamic_link) { if (frappe.dynamic_link) {
if (!doc[frappe.dynamic_link.fieldname]) { if (!doc[frappe.dynamic_link.fieldname]) {
frappe.throw( cur_frm.scroll_to_field(frappe.dynamic_link.fieldname);
__("Please set {0}", [ frappe.show_alert({
message: __("Please set {0} first.", [
__(frappe.meta.get_label(doc.doctype, frappe.dynamic_link.fieldname, doc.name)), __(frappe.meta.get_label(doc.doctype, frappe.dynamic_link.fieldname, doc.name)),
]) ]),
); indicator: "orange",
});
} }
return { return {
@@ -70,11 +76,13 @@ $.extend(erpnext.queries, {
address_query: function (doc) { address_query: function (doc) {
if (frappe.dynamic_link) { if (frappe.dynamic_link) {
if (!doc[frappe.dynamic_link.fieldname]) { if (!doc[frappe.dynamic_link.fieldname]) {
frappe.throw( cur_frm.scroll_to_field(frappe.dynamic_link.fieldname);
__("Please set {0}", [ frappe.show_alert({
message: __("Please set {0} first.", [
__(frappe.meta.get_label(doc.doctype, frappe.dynamic_link.fieldname, doc.name)), __(frappe.meta.get_label(doc.doctype, frappe.dynamic_link.fieldname, doc.name)),
]) ]),
); indicator: "orange",
});
} }
return { return {
@@ -89,7 +97,13 @@ $.extend(erpnext.queries, {
company_address_query: function (doc) { company_address_query: function (doc) {
if (!doc.company) { if (!doc.company) {
frappe.throw(__("Please set {0}", [__(frappe.meta.get_label(doc.doctype, "company", doc.name))])); cur_frm.scroll_to_field("company");
frappe.show_alert({
message: __("Please set {0} first.", [
__(frappe.meta.get_label(doc.doctype, "company", doc.name)),
]),
indicator: "orange",
});
} }
return { return {
@@ -110,9 +124,13 @@ $.extend(erpnext.queries, {
supplier_filter: function (doc) { supplier_filter: function (doc) {
if (!doc.supplier) { if (!doc.supplier) {
frappe.throw( cur_frm.scroll_to_field("supplier");
__("Please set {0}", [__(frappe.meta.get_label(doc.doctype, "supplier", doc.name))]) frappe.show_alert({
); message: __("Please set {0} first.", [
__(frappe.meta.get_label(doc.doctype, "supplier", doc.name)),
]),
indicator: "orange",
});
} }
return { filters: { supplier: doc.supplier } }; return { filters: { supplier: doc.supplier } };
@@ -120,9 +138,13 @@ $.extend(erpnext.queries, {
lead_filter: function (doc) { lead_filter: function (doc) {
if (!doc.lead) { if (!doc.lead) {
frappe.throw( cur_frm.scroll_to_field("lead");
__("Please specify a {0}", [__(frappe.meta.get_label(doc.doctype, "lead", doc.name))]) frappe.show_alert({
); message: __("Please specify a {0} first.", [
__(frappe.meta.get_label(doc.doctype, "lead", doc.name)),
]),
indicator: "orange",
});
} }
return { filters: { lead: doc.lead } }; return { filters: { lead: doc.lead } };