From 7462de66ce099391bbb11f0c566c92136d9539c1 Mon Sep 17 00:00:00 2001
From: Marica <maricadsouza221197@gmail.com>
Date: Tue, 28 May 2024 15:28:02 +0530
Subject: [PATCH] feat: Add Party details to Serial No Ledger Report (#41656)

- Since no party details are present in Serial No anymore, it is hard to get a view of which SN was sold to/purchased from which party
- Add Party fields to report

(cherry picked from commit e3cf53a8b766b0315f460e73d2c5d797d9b19334)
---
 .../serial_no_ledger/serial_no_ledger.py      | 28 +++++++++++++++++++
 1 file changed, 28 insertions(+)

diff --git a/erpnext/stock/report/serial_no_ledger/serial_no_ledger.py b/erpnext/stock/report/serial_no_ledger/serial_no_ledger.py
index f229f73e683..6ef02724f65 100644
--- a/erpnext/stock/report/serial_no_ledger/serial_no_ledger.py
+++ b/erpnext/stock/report/serial_no_ledger/serial_no_ledger.py
@@ -9,6 +9,9 @@ from frappe import _
 from erpnext.stock.doctype.serial_no.serial_no import get_serial_nos as get_serial_nos_from_sle
 from erpnext.stock.stock_ledger import get_stock_ledger_entries
 
+BUYING_VOUCHER_TYPES = ["Purchase Invoice", "Purchase Receipt", "Subcontracting Receipt"]
+SELLING_VOUCHER_TYPES = ["Sales Invoice", "Delivery Note"]
+
 
 def execute(filters=None):
 	columns = get_columns(filters)
@@ -72,6 +75,20 @@ def get_columns(filters):
 			"fieldname": "qty",
 			"width": 150,
 		},
+		{
+			"label": _("Party Type"),
+			"fieldtype": "Link",
+			"fieldname": "party_type",
+			"options": "DocType",
+			"width": 90,
+		},
+		{
+			"label": _("Party"),
+			"fieldtype": "Dynamic Link",
+			"fieldname": "party",
+			"options": "party_type",
+			"width": 120,
+		},
 	]
 
 	return columns
@@ -102,6 +119,17 @@ def get_data(filters):
 			}
 		)
 
+		# get party details depending on the voucher type
+		party_field = (
+			"supplier"
+			if row.voucher_type in BUYING_VOUCHER_TYPES
+			else ("customer" if row.voucher_type in SELLING_VOUCHER_TYPES else None)
+		)
+		args.party_type = party_field.title() if party_field else None
+		args.party = (
+			frappe.db.get_value(row.voucher_type, row.voucher_no, party_field) if party_field else None
+		)
+
 		serial_nos = []
 		if row.serial_no:
 			parsed_serial_nos = get_serial_nos_from_sle(row.serial_no)