CalvinBackup/erpnext
1
0
Fork 0
mirror of https://github.com/frappe/erpnext.git synced 2026-03-15 16:28:20 +00:00
Code Issues Packages Projects Releases Wiki Activity

fix: reposting validation related PCV

Browse Source 
(cherry picked from commit 194f1dc674)
This commit is contained in:
Rohit Waghchaure
2024-06-17 16:51:46 +05:30
committed by Mergify
parent 75edb7708f
commit 794ade832f
1 changed files with 6 additions and 14 deletions
Download Patch File Download Diff File Expand all files Collapse all files

20
erpnext/stock/doctype/repost_item_valuation/repost_item_valuation.py
View File

@@ -77,7 +77,7 @@ class RepostItemValuation(Document):
def validate_period_closing_voucher(self): def validate_period_closing_voucher(self):
# Period Closing Voucher # Period Closing Voucher
year_end_date = self.get_max_year_end_date(self.company) year_end_date = self.get_max_period_closing_date(self.company)
if year_end_date and getdate(self.posting_date) <= getdate(year_end_date): if year_end_date and getdate(self.posting_date) <= getdate(year_end_date):
date = frappe.format(year_end_date, "Date") date = frappe.format(year_end_date, "Date")
msg = f"Due to period closing, you cannot repost item valuation before {date}" msg = f"Due to period closing, you cannot repost item valuation before {date}"
@@ -120,24 +120,16 @@ class RepostItemValuation(Document):
return frappe.get_all("Closing Stock Balance", fields=["name", "to_date"], filters=filters) return frappe.get_all("Closing Stock Balance", fields=["name", "to_date"], filters=filters)
@staticmethod @staticmethod
def get_max_year_end_date(company): def get_max_period_closing_date(company):
data = frappe.get_all( table = frappe.qb.DocType("Period Closing Voucher")
"Period Closing Voucher", fields=["fiscal_year"], filters={"docstatus": 1, "company": company}
)
if not data:
return
fiscal_years = [d.fiscal_year for d in data]
table = frappe.qb.DocType("Fiscal Year")
query = ( query = (
frappe.qb.from_(table) frappe.qb.from_(table)
.select(Max(table.year_end_date)) .select(Max(table.posting_date))
.where((table.name.isin(fiscal_years)) & (table.disabled == 0)) .where((table.company == company) & (table.docstatus == 1))
).run() ).run()
return query[0][0] if query else None return query[0][0] if query and query[0][0] else None
def validate_accounts_freeze(self): def validate_accounts_freeze(self):
acc_settings = frappe.db.get_value( acc_settings = frappe.db.get_value(