From 85c6480b412cc3d76c180fbc80b65afe6061ba18 Mon Sep 17 00:00:00 2001
From: Himanshu <himanshuwarekar@yahoo.com>
Date: Mon, 3 Feb 2020 16:16:42 +0530
Subject: [PATCH] fix(Report): Quality Review report sql fix (#20425)

* fix: report fix

* fix: add QM permission

* fix: add QM permission
---
 .../quality_review/quality_review.json        | 14 ++++++-
 .../report/review/review.json                 | 38 ++++++++++---------
 2 files changed, 34 insertions(+), 18 deletions(-)

diff --git a/erpnext/quality_management/doctype/quality_review/quality_review.json b/erpnext/quality_management/doctype/quality_review/quality_review.json
index bd5e9351f46..a345dac026d 100644
--- a/erpnext/quality_management/doctype/quality_review/quality_review.json
+++ b/erpnext/quality_management/doctype/quality_review/quality_review.json
@@ -73,7 +73,7 @@
    "reqd": 1
   }
  ],
- "modified": "2019-05-26 23:12:47.302189",
+ "modified": "2020-02-01 10:57:27.119312",
  "modified_by": "Administrator",
  "module": "Quality Management",
  "name": "Quality Review",
@@ -102,6 +102,18 @@
    "role": "All",
    "share": 1,
    "write": 1
+  },
+  {
+   "create": 1,
+   "delete": 1,
+   "email": 1,
+   "export": 1,
+   "print": 1,
+   "read": 1,
+   "report": 1,
+   "role": "Quality Manager",
+   "share": 1,
+   "write": 1
   }
  ],
  "sort_field": "modified",
diff --git a/erpnext/quality_management/report/review/review.json b/erpnext/quality_management/report/review/review.json
index 7fce2d4c57c..7fff0fdca6c 100644
--- a/erpnext/quality_management/report/review/review.json
+++ b/erpnext/quality_management/report/review/review.json
@@ -1,24 +1,28 @@
 {
- "add_total_row": 0, 
- "creation": "2018-10-16 12:28:43.651915", 
- "disabled": 0, 
- "docstatus": 0, 
- "doctype": "Report", 
- "idx": 0, 
- "is_standard": "Yes", 
- "modified": "2018-10-16 15:23:25.667237", 
- "modified_by": "Administrator", 
- "module": "Quality Management", 
- "name": "Review", 
- "owner": "Administrator", 
- "prepared_report": 0, 
- "query": "SELECT\n  `tabQuality Action`.name as \"Name:Data:200\",\n  `tabQuality Action`.action as \"Action:Select/[corrective,Preventive]:200\",\n  `tabQuality Action`.review as \"Review:Link/Quality Review:200\",\n  `tabQuality Action`.date as \"Date:Date:120\",\n  `tabQuality Action`.status as \"Status:Select/Planned:150\"\nFROM\n  `tabQuality Action`\nWHERE\n  `tabQuality Action`.type='Quality Review'\n  \n  ", 
- "ref_doctype": "Quality Action", 
- "report_name": "Review", 
- "report_type": "Query Report", 
+ "add_total_row": 0,
+ "creation": "2018-10-16 12:28:43.651915",
+ "disable_prepared_report": 0,
+ "disabled": 0,
+ "docstatus": 0,
+ "doctype": "Report",
+ "idx": 0,
+ "is_standard": "Yes",
+ "modified": "2020-02-01 11:04:47.299453",
+ "modified_by": "Administrator",
+ "module": "Quality Management",
+ "name": "Review",
+ "owner": "Administrator",
+ "prepared_report": 0,
+ "query": "SELECT\n  `tabQuality Action`.name as \"Name:Data:200\",\n  `tabQuality Action`.corrective_preventive as \"Action:Select/[Corrective,Preventive]:200\",\n  `tabQuality Action`.document_type as \"Document Type:Select/[Quality Review, Quality Feedback]:200\",\n  `tabQuality Action`.date as \"Date:Date:120\",\n  `tabQuality Action`.status as \"Status:Select/Planned:150\"\nFROM\n  `tabQuality Action`\nWHERE\n  `tabQuality Action`.document_type='Quality Review'\n  \n  ",
+ "ref_doctype": "Quality Action",
+ "report_name": "Review",
+ "report_type": "Query Report",
  "roles": [
   {
    "role": "System Manager"
+  },
+  {
+   "role": "Quality Manager"
   }
  ]
 }
\ No newline at end of file