From 8e5327a0e0890060ade7f486e028dd021ff5ecc9 Mon Sep 17 00:00:00 2001 From: Rucha Mahabal Date: Fri, 22 Apr 2022 21:33:24 +0530 Subject: [PATCH] fix: clear property child table on changing employee --- erpnext/hr/employee_property_update.js | 21 ++++++++++++++------- 1 file changed, 14 insertions(+), 7 deletions(-) diff --git a/erpnext/hr/employee_property_update.js b/erpnext/hr/employee_property_update.js index b11683347c2..86130bf7930 100644 --- a/erpnext/hr/employee_property_update.js +++ b/erpnext/hr/employee_property_update.js @@ -10,13 +10,20 @@ frappe.ui.form.on(cur_frm.doctype, { }, onload: function(frm) { - if (frm.doc.__islocal) { - if (frm.doctype == "Employee Promotion") { - frm.clear_table("promotion_details"); - } else if (frm.doctype == "Employee Transfer") { - frm.clear_table("transfer_details"); - } - } + if (frm.doc.__islocal) + frm.trigger("clear_property_table"); + }, + + employee: function(frm) { + frm.trigger("clear_property_table"); + }, + + clear_property_table: function(frm) { + let table = (frm.doctype == "Employee Promotion") ? "promotion_details" : "transfer_details"; + frm.clear_table(table); + frm.refresh_field(table); + + frm.fields_dict[table].grid.wrapper.find(".grid-add-row").hide(); }, refresh: function(frm) {