From 950bf682c3b54cb4dc82c97d711f82b5b8eb4968 Mon Sep 17 00:00:00 2001 From: diptanilsaha Date: Sat, 7 Mar 2026 14:20:46 +0530 Subject: [PATCH] refactor(support): type annotations for whitelisted methods --- erpnext/support/doctype/issue/issue.py | 2 +- .../service_level_agreement/service_level_agreement.py | 6 +++--- 2 files changed, 4 insertions(+), 4 deletions(-) diff --git a/erpnext/support/doctype/issue/issue.py b/erpnext/support/doctype/issue/issue.py index 89b666a077b..32aba988cce 100644 --- a/erpnext/support/doctype/issue/issue.py +++ b/erpnext/support/doctype/issue/issue.py @@ -118,7 +118,7 @@ class Issue(Document): communication.save() @frappe.whitelist() - def split_issue(self, subject, communication_id): + def split_issue(self, subject: str, communication_id: str): # Bug: Pressing enter doesn't send subject from copy import deepcopy diff --git a/erpnext/support/doctype/service_level_agreement/service_level_agreement.py b/erpnext/support/doctype/service_level_agreement/service_level_agreement.py index b39f1ce34a9..f0f8e24ec90 100644 --- a/erpnext/support/doctype/service_level_agreement/service_level_agreement.py +++ b/erpnext/support/doctype/service_level_agreement/service_level_agreement.py @@ -427,7 +427,7 @@ def get_customer_territory(customer): @frappe.whitelist() -def get_service_level_agreement_filters(doctype, name, customer=None): +def get_service_level_agreement_filters(doctype: str, name: str, customer: str | None = None): if not frappe.db.get_single_value("Support Settings", "track_service_level_agreement"): return @@ -780,7 +780,7 @@ def get_response_and_resolution_duration(doc): @frappe.whitelist() -def reset_service_level_agreement(doctype: str, docname: str, reason, user): +def reset_service_level_agreement(doctype: str, docname: str, reason: str, user: str): if not frappe.db.get_single_value("Support Settings", "allow_resetting_service_level_agreement"): frappe.throw(_("Allow Resetting Service Level Agreement from Support Settings.")) @@ -1034,7 +1034,7 @@ def get_tz(user): @frappe.whitelist() -def get_user_time(user, to_string=False): +def get_user_time(user: str, to_string: bool = False): return get_datetime_str(now_datetime(user)) if to_string else now_datetime(user)