From 9c428ebfba7063abd3c48a34b9c1bcdbcbc51fa6 Mon Sep 17 00:00:00 2001 From: rohitwaghchaure Date: Mon, 9 Sep 2019 13:20:15 +0530 Subject: [PATCH] fix: not able to save item because price list has disabled (#18965) --- erpnext/stock/doctype/item_price/item_price.py | 14 ++++++++++---- 1 file changed, 10 insertions(+), 4 deletions(-) diff --git a/erpnext/stock/doctype/item_price/item_price.py b/erpnext/stock/doctype/item_price/item_price.py index 30675b54b3e..4c496cb59a7 100644 --- a/erpnext/stock/doctype/item_price/item_price.py +++ b/erpnext/stock/doctype/item_price/item_price.py @@ -32,10 +32,16 @@ class ItemPrice(Document): def update_price_list_details(self): if self.price_list: - self.buying, self.selling, self.currency = \ - frappe.db.get_value("Price List", - {"name": self.price_list, "enabled": 1}, - ["buying", "selling", "currency"]) + price_list_details = frappe.db.get_value("Price List", + {"name": self.price_list, "enabled": 1}, + ["buying", "selling", "currency"]) + + if not price_list_details: + link = frappe.utils.get_link_to_form('Price List', self.price_list) + frappe.throw("The price list {0} does not exists or disabled". + format(link)) + + self.buying, self.selling, self.currency = price_list_details def update_item_details(self): if self.item_code: