fix: prevent self in "Reports To" dropdown (UI-level check)

Ensures employee cannot select themselves in the "Reports To" field via UI.
This complements server-side validation by improving UX.

(cherry picked from commit 608d38a172)
This commit is contained in:
Anjali Patel
2025-08-13 09:33:54 +00:00
committed by Mergify
parent ae90ee3f17
commit 9e8bb9b235

View File

@@ -11,7 +11,13 @@ erpnext.setup.EmployeeController = class EmployeeController extends frappe.ui.fo
}; };
}; };
this.frm.fields_dict.reports_to.get_query = function (doc, cdt, cdn) { this.frm.fields_dict.reports_to.get_query = function (doc, cdt, cdn) {
return { query: "erpnext.controllers.queries.employee_query" }; // return { query: "erpnext.controllers.queries.employee_query" };
return {
filters: [
["status", "=", "Active"], // only active employees
["name", "!=", doc.name] // exclude self
]
};
}; };
} }