From a499b7e0469f4ce807228b80e7309a49b5202b37 Mon Sep 17 00:00:00 2001
From: Mihir Kandoi <kandoimihir@gmail.com>
Date: Thu, 19 Feb 2026 10:18:26 +0530
Subject: [PATCH] fix: reservation based on field should be read only in SRE

(cherry picked from commit 21452b4c6efa8659801d888b5b1445750789a8c1)
---
 .../stock_reservation_entry/stock_reservation_entry.json   | 7 +++----
 1 file changed, 3 insertions(+), 4 deletions(-)

diff --git a/erpnext/stock/doctype/stock_reservation_entry/stock_reservation_entry.json b/erpnext/stock/doctype/stock_reservation_entry/stock_reservation_entry.json
index 795e7eebf35..a959cc4c14e 100644
--- a/erpnext/stock/doctype/stock_reservation_entry/stock_reservation_entry.json
+++ b/erpnext/stock/doctype/stock_reservation_entry/stock_reservation_entry.json
@@ -265,7 +265,6 @@
    "label": "Serial and Batch Reservation"
   },
   {
-   "allow_on_submit": 1,
    "default": "Qty",
    "depends_on": "eval: parent.has_serial_no || parent.has_batch_no",
    "fieldname": "reservation_based_on",
@@ -273,7 +272,7 @@
    "label": "Reservation Based On",
    "no_copy": 1,
    "options": "Qty\nSerial and Batch",
-   "read_only_depends_on": "eval: (doc.delivered_qty > 0 || doc.from_voucher_type == \"Pick List\")"
+   "read_only": 1
   },
   {
    "fieldname": "column_break_7dxj",
@@ -343,11 +342,11 @@
  "index_web_pages_for_search": 1,
  "is_submittable": 1,
  "links": [],
- "modified": "2025-11-10 16:09:10.380024",
+ "modified": "2026-02-19 10:17:28.695394",
  "modified_by": "Administrator",
  "module": "Stock",
  "name": "Stock Reservation Entry",
- "naming_rule": "Expression (old style)",
+ "naming_rule": "Expression",
  "owner": "Administrator",
  "permissions": [
   {