From a54d965d6dae0b9b0e043e6a1dedbfdc447571a6 Mon Sep 17 00:00:00 2001 From: Ankush Menat Date: Mon, 26 May 2025 14:57:11 +0530 Subject: [PATCH] perf: validate variant change only if value changed --- erpnext/stock/doctype/item/item.py | 5 ++++- 1 file changed, 4 insertions(+), 1 deletion(-) diff --git a/erpnext/stock/doctype/item/item.py b/erpnext/stock/doctype/item/item.py index a8e36c533bc..7400a34b3f2 100644 --- a/erpnext/stock/doctype/item/item.py +++ b/erpnext/stock/doctype/item/item.py @@ -793,7 +793,10 @@ class Item(Document): ) def validate_has_variants(self): - if not self.has_variants and frappe.db.get_value("Item", self.name, "has_variants"): + if self.is_new(): + return + + if not self.has_variants and self.has_value_changed("has_variants"): if frappe.db.exists("Item", {"variant_of": self.name}): frappe.throw(_("Item has variants."))