From a873ae0d9f0157ce69c48a26277097eff710af9a Mon Sep 17 00:00:00 2001
From: Deepesh Garg <deepeshgarg6@gmail.com>
Date: Mon, 4 Jan 2021 14:23:31 +0530
Subject: [PATCH] fix: Check for custom dimensions

---
 .../public/js/utils/dimension_tree_filter.js  | 30 ++++++++++---------
 1 file changed, 16 insertions(+), 14 deletions(-)

diff --git a/erpnext/public/js/utils/dimension_tree_filter.js b/erpnext/public/js/utils/dimension_tree_filter.js
index 319cbd2b5d5..96e181788e3 100644
--- a/erpnext/public/js/utils/dimension_tree_filter.js
+++ b/erpnext/public/js/utils/dimension_tree_filter.js
@@ -23,22 +23,24 @@ erpnext.accounts.dimensions = {
 	},
 
 	setup_filters(frm, doctype) {
-		this.accounting_dimensions.forEach((dimension) => {
-			frappe.model.with_doctype(dimension['document_type'], () => {
-				let parent_fields = [];
-				frappe.meta.get_docfields(doctype).forEach((df) => {
-					if (df.fieldtype === 'Link' && df.options === 'Account') {
-						parent_fields.push(df.fieldname);
-					} else if (df.fieldtype === 'Table') {
-						this.setup_child_filters(frm, df.options, df.fieldname, dimension['fieldname']);
-					}
+		if (this.accounting_dimensions) {
+			this.accounting_dimensions.forEach((dimension) => {
+				frappe.model.with_doctype(dimension['document_type'], () => {
+					let parent_fields = [];
+					frappe.meta.get_docfields(doctype).forEach((df) => {
+						if (df.fieldtype === 'Link' && df.options === 'Account') {
+							parent_fields.push(df.fieldname);
+						} else if (df.fieldtype === 'Table') {
+							this.setup_child_filters(frm, df.options, df.fieldname, dimension['fieldname']);
+						}
 
-					if (frappe.meta.has_field(doctype, dimension['fieldname'])) {
-						this.setup_account_filters(frm, dimension['fieldname'], parent_fields);
-					}
+						if (frappe.meta.has_field(doctype, dimension['fieldname'])) {
+							this.setup_account_filters(frm, dimension['fieldname'], parent_fields);
+						}
+					});
 				});
 			});
-		});
+		}
 	},
 
 	setup_child_filters(frm, doctype, parentfield, dimension) {
@@ -91,7 +93,7 @@ erpnext.accounts.dimensions = {
 	},
 
 	copy_dimension_from_first_row(frm, cdt, cdn, fieldname) {
-		if (frappe.meta.has_field(frm.doctype, fieldname)) {
+		if (frappe.meta.has_field(frm.doctype, fieldname) && this.accounting_dimensions) {
 			this.accounting_dimensions.forEach((dimension) => {
 				let row = frappe.get_doc(cdt, cdn);
 				frm.script_manager.copy_from_first_row(fieldname, row, [dimension['fieldname']]);