From a8ea3efae29200d470435dc665ca00899b356d76 Mon Sep 17 00:00:00 2001 From: Saurabh Date: Tue, 14 Feb 2023 13:14:58 +0530 Subject: [PATCH] fix: validate working day list against holidays --- erpnext/payroll/doctype/salary_slip/salary_slip.py | 2 ++ 1 file changed, 2 insertions(+) diff --git a/erpnext/payroll/doctype/salary_slip/salary_slip.py b/erpnext/payroll/doctype/salary_slip/salary_slip.py index 995f4dc0022..302c0d2853a 100644 --- a/erpnext/payroll/doctype/salary_slip/salary_slip.py +++ b/erpnext/payroll/doctype/salary_slip/salary_slip.py @@ -326,6 +326,8 @@ class SalarySlip(TransactionBase): if not cint(include_holidays_in_total_working_days): working_days -= len(holidays) + working_days_list = [cstr(day) for day in working_days_list if cstr(day) not in holidays] + if working_days < 0: frappe.throw(_("There are more holidays than working days this month."))