CalvinBackup/erpnext
1
0
Fork 0
mirror of https://github.com/frappe/erpnext.git synced 2026-02-14 18:23:55 +00:00
Code Issues Packages Projects Releases Wiki Activity

fix: add validation to reject empty readings

Browse Source 
(cherry picked from commit 405d901514)
This commit is contained in:
Pugazhendhi Velu
2025-11-05 17:34:55 +00:00
committed by Mergify
parent 5bb2e8a8ff
commit ac0375fc2e
1 changed files with 3 additions and 1 deletions
Download Patch File Download Diff File Expand all files Collapse all files

4
erpnext/stock/doctype/quality_inspection/quality_inspection.py
View File

@@ -283,9 +283,11 @@ class QualityInspection(Document):
def min_max_criteria_passed(self, reading): def min_max_criteria_passed(self, reading):
"""Determine whether all readings fall in the acceptable range.""" """Determine whether all readings fall in the acceptable range."""
has_reading = False
for i in range(1, 11): for i in range(1, 11):
reading_value = reading.get("reading_" + str(i)) reading_value = reading.get("reading_" + str(i))
if reading_value is not None and reading_value.strip(): if reading_value is not None and reading_value.strip():
has_reading = True
result = ( result = (
flt(reading.get("min_value")) flt(reading.get("min_value"))
<= parse_float(reading_value) <= parse_float(reading_value)
@@ -293,7 +295,7 @@ class QualityInspection(Document):
) )
if not result: if not result:
return False return False
return True return has_reading
def set_status_based_on_acceptance_formula(self, reading): def set_status_based_on_acceptance_formula(self, reading):
if not reading.acceptance_formula: if not reading.acceptance_formula: