From 9cb7c279a47a2100569983ba9d938d219704f89e Mon Sep 17 00:00:00 2001 From: Kishan0330 Date: Wed, 12 Jun 2024 21:46:30 +0530 Subject: [PATCH 1/2] fix: download materials request plan in production plan (cherry picked from commit 6e55651795d7df39cc7cd2fd052809db22794d53) --- .../doctype/production_plan/production_plan.js | 13 +++++++------ 1 file changed, 7 insertions(+), 6 deletions(-) diff --git a/erpnext/manufacturing/doctype/production_plan/production_plan.js b/erpnext/manufacturing/doctype/production_plan/production_plan.js index f57adc5db2e..9f7cb32c1c6 100644 --- a/erpnext/manufacturing/doctype/production_plan/production_plan.js +++ b/erpnext/manufacturing/doctype/production_plan/production_plan.js @@ -400,17 +400,18 @@ frappe.ui.form.on("Production Plan", { }, download_materials_required(frm) { - const warehouses_data = [ - { - warehouse: frm.doc.for_warehouse, - }, - ]; + const warehousesData = []; + + if (frm.doc.for_warehouse) { + warehousesData.push({ warehouse: frm.doc.for_warehouse }); + } + const fields = [ { fieldname: "warehouses", fieldtype: "Table MultiSelect", label: __("Warehouses"), - default: warehouses_data, + default: warehousesData, options: "Production Plan Material Request Warehouse", reqd: 1, get_query: function () { From 164973a42cd827e289b95bfc05b0fa18ac636752 Mon Sep 17 00:00:00 2001 From: Kishan0330 Date: Wed, 12 Jun 2024 22:08:29 +0530 Subject: [PATCH 2/2] refactor: change warehousesData variable name (cherry picked from commit f4e369977a6592ffd2ed4e6c3ce7179fc4fa27a0) --- .../doctype/production_plan/production_plan.js | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/erpnext/manufacturing/doctype/production_plan/production_plan.js b/erpnext/manufacturing/doctype/production_plan/production_plan.js index 9f7cb32c1c6..5b4ef233926 100644 --- a/erpnext/manufacturing/doctype/production_plan/production_plan.js +++ b/erpnext/manufacturing/doctype/production_plan/production_plan.js @@ -400,10 +400,10 @@ frappe.ui.form.on("Production Plan", { }, download_materials_required(frm) { - const warehousesData = []; + const warehouses_data = []; if (frm.doc.for_warehouse) { - warehousesData.push({ warehouse: frm.doc.for_warehouse }); + warehouses_data.push({ warehouse: frm.doc.for_warehouse }); } const fields = [ @@ -411,7 +411,7 @@ frappe.ui.form.on("Production Plan", { fieldname: "warehouses", fieldtype: "Table MultiSelect", label: __("Warehouses"), - default: warehousesData, + default: warehouses_data, options: "Production Plan Material Request Warehouse", reqd: 1, get_query: function () {