diff --git a/erpnext/accounts/doctype/asset/asset.py b/erpnext/accounts/doctype/asset/asset.py index b28aaa9eed3..da73218b257 100644 --- a/erpnext/accounts/doctype/asset/asset.py +++ b/erpnext/accounts/doctype/asset/asset.py @@ -80,7 +80,7 @@ class Asset(Document): frappe.throw(_("Number of Depreciations Booked cannot be greater than Total Number of Depreciations")) if self.next_depreciation_date and getdate(self.next_depreciation_date) < getdate(nowdate()): - frappe.throw(_("Next Depreciation Date must be on or after today")) + frappe.msgprint(_("Next Depreciation Date is entered as past date")) if (flt(self.value_after_depreciation) > flt(self.expected_value_after_useful_life) and not self.next_depreciation_date): diff --git a/erpnext/patches.txt b/erpnext/patches.txt index 8ab34dee974..73d1f832dd0 100644 --- a/erpnext/patches.txt +++ b/erpnext/patches.txt @@ -328,4 +328,5 @@ erpnext.patches.v7_0.update_conversion_factor_in_supplier_quotation_item erpnext.patches.v7_1.move_sales_invoice_from_parent_to_child_timesheet execute:frappe.db.sql("update `tabTimesheet` ts, `tabEmployee` emp set ts.employee_name = emp.employee_name where emp.name = ts.employee and ts.employee_name is null and ts.employee is not null") erpnext.patches.v7_1.update_lead_source -erpnext.patches.v7_1.fix_link_for_customer_from_lead \ No newline at end of file +erpnext.patches.v7_1.fix_link_for_customer_from_lead +erpnext.patches.v7_0.update_mode_of_payment_type diff --git a/erpnext/patches/v7_0/update_mode_of_payment_type.py b/erpnext/patches/v7_0/update_mode_of_payment_type.py new file mode 100644 index 00000000000..9292a1be1b9 --- /dev/null +++ b/erpnext/patches/v7_0/update_mode_of_payment_type.py @@ -0,0 +1,29 @@ +from __future__ import unicode_literals +import frappe +from frappe.utils import flt + +def execute(): + frappe.reload_doc('accounts', 'doctype', 'mode_of_payment') + + frappe.db.sql(""" update `tabMode of Payment` set type = 'Cash' where (type is null or type = '') and name = 'Cash'""") + + for data in frappe.db.sql("""select name from `tabSales Invoice` where is_pos=1 and docstatus<2 and + (ifnull(paid_amount, 0) - ifnull(change_amount, 0)) > ifnull(grand_total, 0) and modified > '2016-05-01'""", as_dict=1): + if data.name: + si_doc = frappe.get_doc("Sales Invoice", data.name) + remove_payment = [] + mode_of_payment = [d.mode_of_payment for d in si_doc.payments if flt(d.amount) > 0] + if mode_of_payment != set(mode_of_payment): + for payment_data in si_doc.payments: + if payment_data.idx != 1 and payment_data.amount == si_doc.grand_total: + remove_payment.append(payment_data) + frappe.db.sql(""" delete from `tabSales Invoice Payment` + where name = %(name)s""", {'name': payment_data.name}) + + if len(remove_payment) > 0: + for d in remove_payment: + si_doc.remove(d) + + si_doc.set_paid_amount() + si_doc.db_set("paid_amount", si_doc.paid_amount, update_modified = False) + si_doc.db_set("base_paid_amount", si_doc.base_paid_amount, update_modified = False) \ No newline at end of file