CalvinBackup/erpnext
1
0
Fork 0
mirror of https://github.com/frappe/erpnext.git synced 2026-03-20 10:45:29 +00:00
Code Issues Packages Projects Releases Wiki Activity

fix: pricing rule rounding

Browse Source 
Consider a pricing rule of 20:1 with recursion enabled, free items
should follow the below progression

|   Qty | Free item qty |
|-------+---------------|
|  0-19 |             0 |
| 20-39 |             1 |
| 40-59 |             2 |

(cherry picked from commit 9bf37426c1)
This commit is contained in:
ruthra kumar
2024-05-02 09:37:24 +05:30
committed by Mergify
parent cd3ca1ee25
commit b93828cd33
1 changed files with 2 additions and 1 deletions
Download Patch File Download Diff File Expand all files Collapse all files

3
erpnext/accounts/doctype/pricing_rule/utils.py
View File

@@ -6,6 +6,7 @@
import copy import copy
import json import json
import math
import frappe import frappe
from frappe import _, bold from frappe import _, bold
@@ -653,7 +654,7 @@ def get_product_discount_rule(pricing_rule, item_details, args=None, doc=None):
if transaction_qty: if transaction_qty:
qty = flt(transaction_qty) * qty / pricing_rule.recurse_for qty = flt(transaction_qty) * qty / pricing_rule.recurse_for
if pricing_rule.round_free_qty: if pricing_rule.round_free_qty:
qty = round(qty) qty = math.floor(qty)
free_item_data_args = { free_item_data_args = {
"item_code": free_item, "item_code": free_item,