From cc9b22ce9f337e37dec400905533b1ce7ca8872d Mon Sep 17 00:00:00 2001 From: UmakanthKaspa Date: Mon, 11 Nov 2024 09:18:09 +0000 Subject: [PATCH 1/2] fix: apply posting date sorting to invoices in Payment Reconciliation similar to payments (cherry picked from commit 0bd83d920d42f461ced04a1ca3a35307b9796d16) --- .../payment_reconciliation/payment_reconciliation.py | 6 +++++- 1 file changed, 5 insertions(+), 1 deletion(-) diff --git a/erpnext/accounts/doctype/payment_reconciliation/payment_reconciliation.py b/erpnext/accounts/doctype/payment_reconciliation/payment_reconciliation.py index 218add540d3..108b6b20301 100644 --- a/erpnext/accounts/doctype/payment_reconciliation/payment_reconciliation.py +++ b/erpnext/accounts/doctype/payment_reconciliation/payment_reconciliation.py @@ -298,7 +298,11 @@ class PaymentReconciliation(Document): if self.invoice_limit: non_reconciled_invoices = non_reconciled_invoices[: self.invoice_limit] - + + non_reconciled_invoices = sorted( + non_reconciled_invoices, key=lambda k: k["posting_date"] or getdate(nowdate()) + ) + self.add_invoice_entries(non_reconciled_invoices) def add_invoice_entries(self, non_reconciled_invoices): From 1019d98c5a83211d5277fb4ff446d39fa5343bbd Mon Sep 17 00:00:00 2001 From: UmakanthKaspa Date: Mon, 11 Nov 2024 18:06:53 +0530 Subject: [PATCH 2/2] fix: remove trailing whitespace (cherry picked from commit d6703eb88b08e358d66bf43a24225db318e1ddc7) --- .../doctype/payment_reconciliation/payment_reconciliation.py | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/erpnext/accounts/doctype/payment_reconciliation/payment_reconciliation.py b/erpnext/accounts/doctype/payment_reconciliation/payment_reconciliation.py index 108b6b20301..ed880a3298f 100644 --- a/erpnext/accounts/doctype/payment_reconciliation/payment_reconciliation.py +++ b/erpnext/accounts/doctype/payment_reconciliation/payment_reconciliation.py @@ -298,11 +298,11 @@ class PaymentReconciliation(Document): if self.invoice_limit: non_reconciled_invoices = non_reconciled_invoices[: self.invoice_limit] - + non_reconciled_invoices = sorted( non_reconciled_invoices, key=lambda k: k["posting_date"] or getdate(nowdate()) ) - + self.add_invoice_entries(non_reconciled_invoices) def add_invoice_entries(self, non_reconciled_invoices):