CalvinBackup/erpnext
1
0
Fork 0
mirror of https://github.com/frappe/erpnext.git synced 2026-02-15 02:33:38 +00:00
Code Issues Packages Projects Releases Wiki Activity

fix: add validation for direct return

Browse Source 
(cherry picked from commit 8379b39aaf)
This commit is contained in:
l0gesh29
2026-01-11 13:52:46 +05:30
committed by Mergify
parent 6dade11d8f
commit bfd6375508
1 changed files with 7 additions and 4 deletions
Download Patch File Download Diff File Expand all files Collapse all files

11
erpnext/accounts/doctype/sales_invoice/sales_invoice.py
View File

@@ -353,6 +353,9 @@ class SalesInvoice(SellingController):
self.set_against_income_account()
if self.is_return and not self.return_against and self.timesheets:
frappe.throw(_("Direct return is not allowed for Timesheet."))
if not self.is_return:
self.validate_time_sheets_are_submitted()
@@ -360,10 +363,10 @@ class SalesInvoice(SellingController):
if self.is_return and self.return_against:
for row in self.timesheets:
if row.billing_hours > 0:
row.billing_hours *= -1
if row.billing_amount > 0:
row.billing_amount *= -1
if row.billing_hours:
row.billing_hours = -abs(row.billing_hours)
if row.billing_amount:
row.billing_amount = -abs(row.billing_amount)
self.update_packing_list()
self.set_billing_hours_and_amount()