From e19161a8eef71d9064fb3c432328a8f06bff9da0 Mon Sep 17 00:00:00 2001 From: Florian HENRY Date: Mon, 16 Jan 2023 21:03:18 +0100 Subject: [PATCH 1/3] fix: Sales ORder Connections on Material Request --- erpnext/selling/doctype/sales_order/sales_order_dashboard.py | 1 - 1 file changed, 1 deletion(-) diff --git a/erpnext/selling/doctype/sales_order/sales_order_dashboard.py b/erpnext/selling/doctype/sales_order/sales_order_dashboard.py index 5c4b57813d3..cbc40bbf90b 100644 --- a/erpnext/selling/doctype/sales_order/sales_order_dashboard.py +++ b/erpnext/selling/doctype/sales_order/sales_order_dashboard.py @@ -14,7 +14,6 @@ def get_data(): }, "internal_links": { "Quotation": ["items", "prevdoc_docname"], - "Material Request": ["items", "material_request"], }, "transactions": [ { From 0639d9e32a4bea0d60b85e367837dc88528b770a Mon Sep 17 00:00:00 2001 From: Deepesh Garg Date: Tue, 17 Jan 2023 08:06:30 +0530 Subject: [PATCH 2/3] chore: Typo in payment reconciliation (#33686) --- .../doctype/payment_reconciliation/payment_reconciliation.py | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/erpnext/accounts/doctype/payment_reconciliation/payment_reconciliation.py b/erpnext/accounts/doctype/payment_reconciliation/payment_reconciliation.py index 13712cee01d..12c0b7a7bf7 100644 --- a/erpnext/accounts/doctype/payment_reconciliation/payment_reconciliation.py +++ b/erpnext/accounts/doctype/payment_reconciliation/payment_reconciliation.py @@ -334,7 +334,7 @@ class PaymentReconciliation(Document): ) # Account Currency has balance - dr_or_cr = "debit" if self.party_type == "Customer" else "debit" + dr_or_cr = "debit" if self.party_type == "Customer" else "credit" reverse_dr_or_cr = "debit" if dr_or_cr == "credit" else "credit" journal_account = frappe._dict( From 64f7f3a12aa5c43427392a74cb6fa9d65fdb83e5 Mon Sep 17 00:00:00 2001 From: Ankush Menat Date: Tue, 17 Jan 2023 10:56:55 +0530 Subject: [PATCH 3/3] chore: ignore b028 Very high false positive count. [skip ci] --- .github/helper/.flake8_strict | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/.github/helper/.flake8_strict b/.github/helper/.flake8_strict index 198ec7bfe54..3e8f7dd11ab 100644 --- a/.github/helper/.flake8_strict +++ b/.github/helper/.flake8_strict @@ -66,7 +66,8 @@ ignore = F841, E713, E712, - B023 + B023, + B028 max-line-length = 200