From d65cd605a1bbc85fd0935c40c7a2c19b9016d736 Mon Sep 17 00:00:00 2001 From: Navin-S-R Date: Tue, 13 Jan 2026 12:16:52 +0530 Subject: [PATCH] fix: move validation to before_cancel --- erpnext/accounts/doctype/journal_entry/journal_entry.py | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/erpnext/accounts/doctype/journal_entry/journal_entry.py b/erpnext/accounts/doctype/journal_entry/journal_entry.py index 1c10208378a..ce435482ae5 100644 --- a/erpnext/accounts/doctype/journal_entry/journal_entry.py +++ b/erpnext/accounts/doctype/journal_entry/journal_entry.py @@ -185,7 +185,7 @@ class JournalEntry(AccountsController): return self._submit() def before_cancel(self): - pass + self.has_asset_adjustment_entry() def cancel(self): if len(self.accounts) > 100: @@ -308,7 +308,6 @@ class JournalEntry(AccountsController): ) self.make_gl_entries(1) JournalTaxWithholding(self).on_cancel() - self.has_asset_adjustment_entry() self.unlink_advance_entry_reference() self.unlink_asset_reference() self.unlink_inter_company_jv()