From de8f6120f322afb1f5499ad512abb577bb54f0ca Mon Sep 17 00:00:00 2001
From: Zarrar <zarrar65@gmail.com>
Date: Wed, 13 Dec 2017 18:36:08 +0530
Subject: [PATCH] [Fix] Restrict domain specific roles (#11975)

* restrict roles to its specific domain

* missing hook for Non Profit
---
 erpnext/domains/agriculture.py | 4 ++++
 erpnext/domains/education.py   | 3 ++-
 erpnext/domains/non_profit.py  | 5 +++++
 erpnext/hooks.py               | 1 +
 4 files changed, 12 insertions(+), 1 deletion(-)

diff --git a/erpnext/domains/agriculture.py b/erpnext/domains/agriculture.py
index 378c5f1c2d5..d605ac7820a 100644
--- a/erpnext/domains/agriculture.py
+++ b/erpnext/domains/agriculture.py
@@ -14,6 +14,10 @@ data = {
 		'Water Analysis',
 		'Weather'
 	],
+	'restricted_roles': [
+		'Agriculture Manager',
+		'Agriculture User'
+	],
 	'modules': [
 		'Agriculture'
 	],
diff --git a/erpnext/domains/education.py b/erpnext/domains/education.py
index eed35459079..e1e363d40a6 100644
--- a/erpnext/domains/education.py
+++ b/erpnext/domains/education.py
@@ -16,7 +16,8 @@ data = {
 	'restricted_roles': [
 		'Student',
 		'Instructor',
-		'Academics User'
+		'Academics User',
+		'Education Manager'
 	],
 	'modules': [
 		'Education'
diff --git a/erpnext/domains/non_profit.py b/erpnext/domains/non_profit.py
index b9683bd558f..81aff02fa61 100644
--- a/erpnext/domains/non_profit.py
+++ b/erpnext/domains/non_profit.py
@@ -10,6 +10,11 @@ data = {
 		'HR',
 		'ToDo'
 	],
+	'restricted_roles': [
+		'Non Profit Manager',
+		'Non Profit Member',
+		'Non Profit Portal User'
+	],
 	'modules': [
 		'Non Profit'
 	],
diff --git a/erpnext/hooks.py b/erpnext/hooks.py
index 53d117cf462..b65908a5072 100644
--- a/erpnext/hooks.py
+++ b/erpnext/hooks.py
@@ -60,6 +60,7 @@ domains = {
 	'Healthcare': 'erpnext.domains.healthcare',
 	'Hospitality': 'erpnext.domains.hospitality',
 	'Manufacturing': 'erpnext.domains.manufacturing',
+	'Non Profit': 'erpnext.domains.non_profit',
 	'Retail': 'erpnext.domains.retail',
 	'Services': 'erpnext.domains.services',
 }