From ea2763432d8ef7dc592b88061ee04cf9c0729e3f Mon Sep 17 00:00:00 2001
From: ruthra kumar <ruthra@erpnext.com>
Date: Wed, 25 Jun 2025 17:40:23 +0530
Subject: [PATCH] refactor: utility to return default supplier scorecards

---
 .../supplier_scorecard/supplier_scorecard.py       | 14 +++++++++++---
 1 file changed, 11 insertions(+), 3 deletions(-)

diff --git a/erpnext/buying/doctype/supplier_scorecard/supplier_scorecard.py b/erpnext/buying/doctype/supplier_scorecard/supplier_scorecard.py
index 7aaaceaed08..c11ee6383dc 100644
--- a/erpnext/buying/doctype/supplier_scorecard/supplier_scorecard.py
+++ b/erpnext/buying/doctype/supplier_scorecard/supplier_scorecard.py
@@ -266,8 +266,8 @@ def get_scorecard_date(period, start_date):
 	return end_date
 
 
-def make_default_records():
-	install_variable_docs = [
+def get_default_scorecard_variables():
+	return [
 		{
 			"param_name": "total_accepted_items",
 			"variable_label": "Total Accepted Items",
@@ -374,7 +374,10 @@ def make_default_records():
 			"path": "get_invoiced_qty",
 		},
 	]
-	install_standing_docs = [
+
+
+def get_default_scorecard_standing():
+	return [
 		{
 			"min_grade": 0.0,
 			"prevent_rfqs": 1,
@@ -425,12 +428,17 @@ def make_default_records():
 		},
 	]
 
+
+def make_default_records():
+	install_variable_docs = get_default_scorecard_variables()
 	for d in install_variable_docs:
 		try:
 			d["doctype"] = "Supplier Scorecard Variable"
 			frappe.get_doc(d).insert()
 		except frappe.NameError:
 			pass
+
+	install_standing_docs = get_default_scorecard_standing()
 	for d in install_standing_docs:
 		try:
 			d["doctype"] = "Supplier Scorecard Standing"