From f5fa757bc68a0c37a73cc4dee873e10b5af42bd7 Mon Sep 17 00:00:00 2001 From: Khushi Rawat <142375893+khushi8112@users.noreply.github.com> Date: Sun, 16 Mar 2025 23:26:25 +0530 Subject: [PATCH] fix(test): failing test cases --- erpnext/assets/doctype/asset/test_asset.py | 15 ++++++++++++--- .../assets/doctype/asset_repair/asset_repair.py | 1 + 2 files changed, 13 insertions(+), 3 deletions(-) diff --git a/erpnext/assets/doctype/asset/test_asset.py b/erpnext/assets/doctype/asset/test_asset.py index 77621d0874c..9ca5e5ee1f0 100644 --- a/erpnext/assets/doctype/asset/test_asset.py +++ b/erpnext/assets/doctype/asset/test_asset.py @@ -1031,10 +1031,14 @@ class TestDepreciationBasics(AssetSetup): asset.submit() asset_depr_schedule_doc = get_asset_depr_schedule_doc(asset.name, "Active") + asset_depr_schedule_doc.asset_doc = asset + asset_depr_schedule_doc.get_finance_book_row() + asset_depr_schedule_doc.fetch_asset_details() + asset_depr_schedule_doc.clear() + asset_depr_schedule_doc._check_is_pro_rata() + asset_depr_schedule_doc.initialize_variables() - depreciation_amount = asset_depr_schedule_doc.get_depreciation_amount( - asset_depr_schedule_doc, asset, 100000, 100000, asset.finance_books[0] - ) + depreciation_amount = asset_depr_schedule_doc.get_depreciation_amount(0) self.assertEqual(depreciation_amount, 30000) def test_make_depr_schedule(self): @@ -1465,6 +1469,11 @@ class TestDepreciationBasics(AssetSetup): submit=1, ) + depr_expense_account = frappe.get_doc("Account", "_Test Depreciations - _TC") + depr_expense_account.root_type = "Expense" + depr_expense_account.parent_account = "Expenses - _TC" + depr_expense_account.save() + post_depreciation_entries(date="2021-01-01") asset.load_from_db() diff --git a/erpnext/assets/doctype/asset_repair/asset_repair.py b/erpnext/assets/doctype/asset_repair/asset_repair.py index 8a4349233e5..8bfbb2c7d21 100644 --- a/erpnext/assets/doctype/asset_repair/asset_repair.py +++ b/erpnext/assets/doctype/asset_repair/asset_repair.py @@ -242,6 +242,7 @@ class AssetRepair(AccountsController): def make_gl_entries(self, cancel=False): if cancel: self.ignore_linked_doctypes = ("GL Entry", "Stock Ledger Entry") + self.save() if flt(self.total_repair_cost) > 0: gl_entries = self.get_gl_entries()