From fa5eae08a05930ff73bbdf13508d12c21fa79be4 Mon Sep 17 00:00:00 2001 From: diptanilsaha Date: Thu, 19 Feb 2026 14:43:24 +0530 Subject: [PATCH] fix(test_purchase_order): validation to create pi from po with terms Fixed the test to check for error while creating Purchase Invoice from unsubmitted Purchase Order --- .../buying/doctype/purchase_order/test_purchase_order.py | 7 +++---- 1 file changed, 3 insertions(+), 4 deletions(-) diff --git a/erpnext/buying/doctype/purchase_order/test_purchase_order.py b/erpnext/buying/doctype/purchase_order/test_purchase_order.py index 9aad9bcac93..3b7c9db5ee9 100644 --- a/erpnext/buying/doctype/purchase_order/test_purchase_order.py +++ b/erpnext/buying/doctype/purchase_order/test_purchase_order.py @@ -543,13 +543,12 @@ class TestPurchaseOrder(IntegrationTestCase): @IntegrationTestCase.change_settings("Accounts Settings", {"automatically_fetch_payment_terms": 1}) def test_make_purchase_invoice_with_terms(self): po = create_purchase_order(do_not_save=True) - - with self.assertRaises(frappe.ValidationError): - make_pi_from_po(po.name) - po.update({"payment_terms_template": "_Test Payment Term Template"}) po.save() + + self.assertRaises(frappe.ValidationError, make_pi_from_po, po.name) + po.submit() self.assertEqual(po.payment_schedule[0].payment_amount, 2500.0)