From fabcfc1fce9231a8c15d1aee96227697ce92c9b8 Mon Sep 17 00:00:00 2001 From: "mergify[bot]" <37929162+mergify[bot]@users.noreply.github.com> Date: Sun, 29 Oct 2023 12:16:34 +0530 Subject: [PATCH] fix(minor): set tax values for item variants (backport #37674) (#37738) * fix: copy all child fields to item variant (cherry picked from commit 5deba1b6f9b03ce5d078d624e339f6b0209a1555) * fix: only update if variant table empty (cherry picked from commit d436a407390c0e0d89c66445539bbb95784be7eb) --------- Co-authored-by: Gursheen Anand --- erpnext/stock/doctype/item/item.py | 2 +- erpnext/stock/get_item_details.py | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-) diff --git a/erpnext/stock/doctype/item/item.py b/erpnext/stock/doctype/item/item.py index 693d33ffb71..e1dd481b075 100644 --- a/erpnext/stock/doctype/item/item.py +++ b/erpnext/stock/doctype/item/item.py @@ -280,7 +280,7 @@ class Item(Document): # add item taxes from template for d in template.get("taxes"): - self.append("taxes", {"item_tax_template": d.item_tax_template}) + self.append("taxes", d) # copy re-order table if empty if not self.get("reorder_levels"): diff --git a/erpnext/stock/get_item_details.py b/erpnext/stock/get_item_details.py index e3fa5a0e7b1..990e03daa1b 100644 --- a/erpnext/stock/get_item_details.py +++ b/erpnext/stock/get_item_details.py @@ -302,7 +302,7 @@ def get_basic_details(args, item, overwrite_warehouse=True): if not item: item = frappe.get_doc("Item", args.get("item_code")) - if item.variant_of: + if item.variant_of and not item.taxes: item.update_template_tables() item_defaults = get_item_defaults(item.name, args.company)