- Cannot determine action on newly mapped DN that hasnt been inserted
- Rows could have been deleted, updated, added, etc. before first save
- In this case , reset packing table
(cherry picked from commit bd41a99c8a)
- Cannot determine action on newly mapped DN that hasnt been inserted
- Rows could have been deleted, updated, added, etc. before first save
- In this case , reset packing table
(cherry picked from commit bd41a99c8a)
- fetch price from price list, use item master valuation rate as fallback fo0r packed item
- use a item code, item row name map to maintain cumulative price
- reset table if item in a row is replaced
- loop over items table only to set price, lesser iterations than packed items table
(cherry picked from commit 2f4d266ee1)
- Smaller functions for updation
- All calls visible from parent function to avoid context switching due to nested calls
(cherry picked from commit 2c14ab0439)
- Create an indexed map of stale packed items table to avoid loops to check if packed item row exists
- Reset packed items if row deletion takes place
- Renamed functions to self-explain them
- Split long function
- Reduce function calls inside function (makes it harder to follow through)
(cherry picked from commit 4c677eafe9)
- `doc_before_save` does not exist via Update Items (updates stuff in the backend so doc isn't considered unsaved/dirty)
- converted more raw sql to qb and ORM
(cherry picked from commit f8a5786542)
- Fix Incorrect packing list for recurring items in the Items table
- Re-organised functions based on external use and order of use
- Deleted `clean_packing_list` function and reduced no.of loops
- Raw SQL to QB
- Minor formatting changes
(cherry picked from commit 3f48fc1898)
- fetch price from price list, use item master valuation rate as fallback fo0r packed item
- use a item code, item row name map to maintain cumulative price
- reset table if item in a row is replaced
- loop over items table only to set price, lesser iterations than packed items table
(cherry picked from commit 2f4d266ee1)
- Smaller functions for updation
- All calls visible from parent function to avoid context switching due to nested calls
(cherry picked from commit 2c14ab0439)
- Create an indexed map of stale packed items table to avoid loops to check if packed item row exists
- Reset packed items if row deletion takes place
- Renamed functions to self-explain them
- Split long function
- Reduce function calls inside function (makes it harder to follow through)
(cherry picked from commit 4c677eafe9)
- `doc_before_save` does not exist via Update Items (updates stuff in the backend so doc isn't considered unsaved/dirty)
- converted more raw sql to qb and ORM
(cherry picked from commit f8a5786542)
- Fix Incorrect packing list for recurring items in the Items table
- Re-organised functions based on external use and order of use
- Deleted `clean_packing_list` function and reduced no.of loops
- Raw SQL to QB
- Minor formatting changes
(cherry picked from commit 3f48fc1898)
* fix: dont try to filter by customer/supplier if None
* test: item query with emtpy supplier
(cherry picked from commit 41a95e5624)
Co-authored-by: Ankush Menat <ankush@frappe.io>
* fix: dont try to filter by customer/supplier if None
* test: item query with emtpy supplier
(cherry picked from commit 41a95e5624)
Co-authored-by: Ankush Menat <ankush@frappe.io>
