Deepesh Garg
1b632b683f
fix: Status check for closed loans
...
(cherry picked from commit 3337ae120c )
2021-10-12 08:11:46 +00:00
mergify[bot]
c5660e8511
Merge pull request #27906 from Anuja-pawar/accounts-settings ( #27912 )
...
fix(Accounts Settings): Update label
(cherry picked from commit e1967870a9 )
Co-authored-by: Anuja Pawar <60467153+Anuja-pawar@users.noreply.github.com >
2021-10-12 12:23:53 +05:30
mergify[bot]
c4338d184e
fix(accounts): Fix issue with fetching loyalty point entries ( #27892 ) ( #27913 )
...
(cherry picked from commit 401e22fb8d )
Co-authored-by: Chillar Anand <chillar@avilpage.com >
2021-10-12 12:23:32 +05:30
Noah Jacob
d598a61556
Merge pull request #27901 from frappe/mergify/bp/version-13-hotfix/pr-27800
...
refactor: updated buying onboarding tours. (backport #27800 )
2021-10-11 16:33:59 +05:30
Noah Jacob
d262d0ac27
refactor: updated onboarding cards and tours
...
(cherry picked from commit f5e0cad6a1 )
2021-10-11 10:04:40 +00:00
mergify[bot]
7dc2f95932
fix: v12 migrate error - unknown column ‘mandatory_depends_on’ (backport #27897 ) ( #27900 )
...
* fix: v12 migrate error - unknown column ‘mandatory_depends_on’ (#27897 )
* fix: v12 doesn't have mandatory_depends_on field
* fix: move update_vehicle_no_reqd_condition to v13
* fix: move update_vehicle_no_reqd_condition to v13
* fix: file name missing .py
* refactor!: add back empty line
* fix: linters issue
(cherry picked from commit 7acdcc70ad )
# Conflicts:
# erpnext/patches.txt
* fix: resolve conflicts
Co-authored-by: Dany Robert <rtdany10@gmail.com >
Co-authored-by: Ankush Menat <ankush@iwebnotes.com >
2021-10-11 10:02:31 +00:00
rohitwaghchaure
cf87c9138e
Merge pull request #27898 from frappe/mergify/bp/version-13-hotfix/pr-27863
...
fix: consolidated report not consider company currency (backport #27863 )
2021-10-11 14:07:51 +05:30
Rohit Waghchaure
1a42f82d14
fix: opening balance to calculate 'Unclosed Fiscal Years Profit / Loss (Credit)'
...
(cherry picked from commit 19d14da0d4 )
2021-10-11 08:37:27 +00:00
Rohit Waghchaure
2c5a0bff47
fix: consolidated report not consider company currency
...
(cherry picked from commit dc4206428d )
2021-10-11 08:37:26 +00:00
mergify[bot]
a831e6b552
fix: bom item query (backport #27890 ) ( #27894 )
...
* fix: bom item query #27890
fix: bom item query
(cherry picked from commit 0a3dd3e954 )
# Conflicts:
# erpnext/manufacturing/doctype/bom/test_bom.py
* fix: resolve conflict
* chore: unused imports
[skip ci]
Co-authored-by: Ankush Menat <ankush@iwebnotes.com >
2021-10-11 12:45:24 +05:30
ChillarAnand
f844c36ab2
fix(CI): Use bugbear instead of flake8-mutable
...
(cherry picked from commit 4dc17a856e )
2021-10-11 11:23:22 +05:30
mergify[bot]
091c2f3023
fix(perf): index creation on voucher_detail_no ( #27866 ) ( #27875 )
...
voucher_detail_no is supposed to have an index, it was added on
on_doctype_update function of table, however this function is only
called if DocType itself is updated and `on_update` is called on
DocType. Stock ledger Entry doctype hasn't changed since addition of
this index in function.
Before: Lack of this index was causing full table scan in
get_future_sle_to_fix function. (~50 seconds in a reposting job)
After: Single row is fetched (~0.5 second in full reposting job)
Learnings:
1. Add simple indexes via doctype only
2. For complex indexes always change doctype.json file for it to take
effect.
(cherry picked from commit 6019f60d0a )
Co-authored-by: Ankush Menat <ankush@iwebnotes.com >
2021-10-08 17:19:41 +05:30
mergify[bot]
119c2f01e1
fix(perf): index creation on voucher_detail_no ( #27866 ) ( #27876 )
...
voucher_detail_no is supposed to have an index, it was added on
on_doctype_update function of table, however this function is only
called if DocType itself is updated and `on_update` is called on
DocType. Stock ledger Entry doctype hasn't changed since addition of
this index in function.
Before: Lack of this index was causing full table scan in
get_future_sle_to_fix function. (~50 seconds in a reposting job)
After: Single row is fetched (~0.5 second in full reposting job)
Learnings:
1. Add simple indexes via doctype only
2. For complex indexes always change doctype.json file for it to take
effect.
(cherry picked from commit 6019f60d0a )
Co-authored-by: Ankush Menat <ankush@iwebnotes.com >
2021-10-08 17:19:34 +05:30
gavin
40aac908d1
fix: Ignore mandatory fields if exist ( #27871 )
...
The goal of this fix is to not break the patch in case of customizations
In this particular case, it's regarding a customized Note DocType with
multiple custom mandatory fields
2021-10-08 15:10:03 +05:30
mergify[bot]
4e6d588ae1
fix: remove readonly from billing address ( #27873 )
...
(cherry picked from commit 41fefa356f )
Co-authored-by: 18alantom <2.alan.tom@gmail.com >
2021-10-08 15:08:45 +05:30
mergify[bot]
504f2f06d3
fix: Salary Slip Label fixes (backport #27865 ) ( #27870 )
...
* fix: Salary Slip Label fixes (#27865 )
Co-authored-by: Rucha Mahabal <ruchamahabal2@gmail.com >
(cherry picked from commit d3d4a3da62 )
# Conflicts:
# erpnext/payroll/doctype/salary_slip/salary_slip.json
* fix: conflicts
Co-authored-by: yadavyk <32797974+yadavyk@users.noreply.github.com >
Co-authored-by: Rucha Mahabal <ruchamahabal2@gmail.com >
2021-10-08 14:16:12 +05:30
mergify[bot]
d96fd60878
fix: update dead links in help_links.js ( #27860 ) ( #27868 )
...
(cherry picked from commit 90a249527d )
Co-authored-by: Kenneth Sequeira <33246109+kennethsequeira@users.noreply.github.com >
2021-10-08 13:31:07 +05:30
Deepesh Garg
d9a219850a
fix: SO delivery Date not getting set via data import ( #27862 )
...
* fix: SO delivery Date not getting set via data import
* fix: logic to add delivery dates
* fix: linting issue
Co-authored-by: Afshan <33727827+AfshanKhan@users.noreply.github.com >
Co-authored-by: Afshan <afshan13k@gmail.com >
2021-10-08 12:38:40 +05:30
mergify[bot]
cb6d884058
fix(Payment Reconciliation): minor ux fixes ( #27779 ) ( #27859 )
...
* fix: minor fixes
* fix: Linters check
* fix: sider check
* fix: kept unallocated payment amount hidden in allocation
* fix: removed Add row button from the tables (redundant)
Co-authored-by: Afshan <33727827+AfshanKhan@users.noreply.github.com >
Co-authored-by: Saqib <nextchamp.saqib@gmail.com >
(cherry picked from commit 5cc3ea0aa7 )
Co-authored-by: Anuja Pawar <60467153+Anuja-pawar@users.noreply.github.com >
2021-10-07 22:47:05 +05:30
mergify[bot]
4102f799dc
fix: trim sales invoice custom field lengths (backport #27665 ) ( #27750 )
...
* fix: trim sales invoice custom field lengths
(cherry picked from commit a7df4227da )
* patch: trim sales invoice custom field lengths
(cherry picked from commit f1fcb385f5 )
# Conflicts:
# erpnext/patches.txt
* fix: do not set length for date field
(cherry picked from commit 83cc597594 )
* fix: merge conflicts
Co-authored-by: Saqib Ansari <nextchamp.saqib@gmail.com >
Co-authored-by: Deepesh Garg <42651287+deepeshgarg007@users.noreply.github.com >
Co-authored-by: Afshan <33727827+AfshanKhan@users.noreply.github.com >
2021-10-07 20:59:07 +05:30
Subin Tom
3c53c5b660
fix: cancelled sales invoices are considered in billed quantity calculation ( #27845 )
...
Co-authored-by: Saqib Ansari <nextchamp.saqib@gmail.com >
Co-authored-by: Afshan <33727827+AfshanKhan@users.noreply.github.com >
2021-10-07 20:36:00 +05:30
mergify[bot]
0a4b3d8129
fix: help links for purchase cycle and JV ( #27856 ) ( #27858 )
...
(cherry picked from commit 07c680d7cc )
Co-authored-by: Kenneth Sequeira <33246109+kennethsequeira@users.noreply.github.com >
2021-10-07 20:29:28 +05:30
mergify[bot]
bad489426a
feat: (Stock Reco) Ignore Empty Stock while fetching items from warehouse ( #27848 )
...
- Added checkbox to `Fetch Items from Warehouse` dialog to ignore empty stock
- fix: Items fetched twice due to Item Defaults
- Improved code readability
(cherry picked from commit 533ee9a401 )
Co-authored-by: marination <maricadsouza221197@gmail.com >
2021-10-07 20:28:08 +05:30
mergify[bot]
729e29d268
fix: update help links for Sales Invoice page ( #27853 ) ( #27854 )
...
(cherry picked from commit 646fd29f0e )
Co-authored-by: Kenneth Sequeira <33246109+kennethsequeira@users.noreply.github.com >
2021-10-07 18:42:06 +05:30
rohitwaghchaure
8108d4761b
Merge pull request #27852 from frappe/mergify/bp/version-13-hotfix/pr-27851
...
feat: option to set the width for the multi-select dialog box (backport #27851 )
2021-10-07 17:39:20 +05:30
Rohit Waghchaure
00cb04df84
feat: option to set the width for the multi-select dialog box
...
(cherry picked from commit 69ffddf747 )
2021-10-07 12:08:58 +00:00
mergify[bot]
dd0cefbeb9
refactor: Clean up mutable defaults and add CI check ( #27828 ) ( #27841 )
...
* refactor: Clean up mutable defaults and add CI check
(cherry picked from commit 772d4753e7 )
Co-authored-by: Chillar Anand <chillar@avilpage.com >
2021-10-07 09:57:35 +00:00
Rohit Waghchaure
d11c215f85
Merge branch 'version-13-pre-release' into version-13
v13.12.1
2021-10-07 11:35:31 +05:30
Rohit Waghchaure
5ea5bfad3d
bumped to version 13.12.1
2021-10-07 11:55:31 +05:50
Anoop
4da5cb36e7
Merge pull request #27812 from akurungadam/fix-appointment-slots
...
fix(healthcare): Availability slots display, disabled Practitioner Schedule
2021-10-07 08:45:56 +05:30
mergify[bot]
56b58cbeea
fix: use ceil in case of whole uoms for reorder qty ( #27834 ) ( #27838 )
...
* fix: use ceil in case of whole uoms for reorder qty
* fix: cache uom query
(cherry picked from commit d4b2471cea )
Co-authored-by: Alan <2.alan.tom@gmail.com >
2021-10-06 18:54:22 +05:30
Marica
cd87931cee
Merge pull request #27833 from frappe/mergify/bp/version-13-pre-release/pr-27713
...
fix: Maintenance Schedule child table status for legacy data (backport #27713 )
2021-10-06 14:08:15 +05:30
Marica
355ae1fca6
Merge branch 'version-13-pre-release' into mergify/bp/version-13-pre-release/pr-27713
2021-10-06 13:42:46 +05:30
mergify[bot]
91baa22d59
fix: remove stale doctypes and add msg for ecommerce refactor (bp #27700 )
...
(cherry picked from commit 6d99bb5ce6 )
Co-authored-by: Ankush Menat <ankush@iwebnotes.com >
2021-10-06 13:37:26 +05:30
marination
af57e1e299
fix: reload doc in patch
...
(cherry picked from commit 6b38778dcb )
2021-10-06 07:57:22 +00:00
marination
1d3ba46107
fix: Add patch to patches.txt
...
(cherry picked from commit 7c47f36a4c )
2021-10-06 07:57:22 +00:00
Marica
65a590ced1
fix: Maintenance Schedule child table status for legacy data ( #27554 )
...
* fix: Maintenance Schedule child table status for legacy data
* fix: Include legacy draft schedules in patch
* fix: Pre-commit formatting
(cherry picked from commit cc143bca0d )
(cherry picked from commit 6ce2111b6d )
2021-10-06 07:57:21 +00:00
Marica
1a68e10742
Merge pull request #27829 from frappe/mergify/bp/version-13-pre-release/pr-27715
...
fix: Batch scans get overwritten on the same row (backport #27668 ) (backport #27715 )
2021-10-06 12:57:39 +05:30
Marica
71f676eedd
Merge pull request #27764 from frappe/mergify/bp/version-13-hotfix/pr-27661
...
refactor: fetching of account balance in chart of accounts (backport #27661 )
2021-10-06 12:56:10 +05:30
mergify[bot]
4fe827e86b
Merge pull request #27715 from frappe/mergify/bp/version-13-hotfix/pr-27668
...
fix: Batch scans get overwritten on the same row (backport #27668 )
(cherry picked from commit 15c9c08261 )
2021-10-06 07:13:00 +00:00
Deepesh Garg
f573840c9f
Merge pull request #27801 from frappe/mergify/bp/version-13-pre-release/pr-27524
...
fix: Tax breakup based on items, missing GST fields (backport #27524 )
2021-10-06 09:33:30 +05:30
Rohit Waghchaure
0bc83deca0
Merge branch 'version-13-pre-release' into version-13
v13.12.0
2021-10-06 00:26:31 +05:30
Rohit Waghchaure
696a01765b
bumped to version 13.12.0
2021-10-06 00:46:31 +05:50
rohitwaghchaure
047debffeb
Merge pull request #27825 from rohitwaghchaure/v13_12_0-change-log
...
chore: change log for v13_12_0
2021-10-06 00:02:19 +05:30
mergify[bot]
e57037b4cf
ci: fail build if asset bundling fails ( #27820 ) ( #27823 )
...
(cherry picked from commit 35e30bdcaf )
Co-authored-by: Ankush Menat <ankush@iwebnotes.com >
2021-10-05 23:59:47 +05:30
Rohit Waghchaure
633cd0c1a8
chore: change log for v13_12_0
2021-10-05 23:44:32 +05:30
Deepesh Garg
51b2fcc8ef
fix: Update setup.py
2021-10-05 21:05:12 +05:30
Deepesh Garg
ff062d501f
fix: Update patches.txt
2021-10-05 21:03:40 +05:30
mergify[bot]
2cbd5a9fcf
fix: removed redundant piece of code ( #27817 ) ( #27821 )
...
(cherry picked from commit cec66d2d10 )
Co-authored-by: Afshan <33727827+AfshanKhan@users.noreply.github.com >
2021-10-05 19:26:58 +05:30
mergify[bot]
89e421a01d
fix: removed redundant piece of code ( #27817 ) ( #27822 )
...
(cherry picked from commit cec66d2d10 )
Co-authored-by: Afshan <33727827+AfshanKhan@users.noreply.github.com >
2021-10-05 19:24:40 +05:30