Deepesh Garg
933d4bfceb
Merge pull request #36711 from frappe/mergify/bp/version-14-hotfix/pr-36710
...
fix: broken consolidated report due to finance book filter (#36710 )
2023-08-19 10:25:11 +05:30
Frappe PR Bot
de3b67c327
chore(release): Bumped to Version 14.35.2
...
## [14.35.2](https://github.com/frappe/erpnext/compare/v14.35.1...v14.35.2 ) (2023-08-18)
### Bug Fixes
* timeout error coming during reposting (backport [#36715 ](https://github.com/frappe/erpnext/issues/36715 )) ([#36716 ](https://github.com/frappe/erpnext/issues/36716 )) ([d5a596d ](d5a596dff1 ))
v14.35.2
2023-08-18 15:30:59 +00:00
mergify[bot]
d5a596dff1
fix: timeout error coming during reposting (backport #36715 ) ( #36716 )
...
fix: timeout error coming during reposting (#36715 )
(cherry picked from commit 620b21fec5 )
Co-authored-by: rohitwaghchaure <rohitw1991@gmail.com >
2023-08-18 20:59:20 +05:30
rohitwaghchaure
620b21fec5
fix: timeout error coming during reposting ( #36715 )
2023-08-18 18:33:04 +05:30
ruthra kumar
5bd2a0923f
fix: broken consolidated report due to finance book filter
...
(cherry picked from commit 96847db0ec )
2023-08-18 09:25:18 +00:00
Deepesh Garg
e62ffa990d
fix: Add company filters for account
...
(cherry picked from commit ecca9cb023 )
# Conflicts:
# erpnext/accounts/doctype/purchase_invoice/test_purchase_invoice.py
2023-08-18 07:08:21 +00:00
Gursheen Anand
01ae513f70
fix: dimension name in remark
...
(cherry picked from commit 4f9242d699 )
2023-08-18 07:08:21 +00:00
Gursheen Anand
37ef6e959b
fix: reset dimension defaults when company changedin test
...
(cherry picked from commit 3f5afb9cac )
2023-08-18 07:08:21 +00:00
Gursheen Anand
2a467a9fbf
fix: clear dimension defaults after test
...
(cherry picked from commit 23e56d3ec1 )
2023-08-18 07:08:20 +00:00
Gursheen Anand
7ac35b496a
fix: fetch acc dimensions correctly when fieldname is different from name
...
(cherry picked from commit e19a6f5dcb )
2023-08-18 07:08:20 +00:00
Gursheen Anand
cdb66bf198
fix: duplicate acc dimension in test
...
(cherry picked from commit b3f6d991b5 )
2023-08-18 07:08:20 +00:00
Gursheen Anand
8530a28c62
test: PI offsetting entry for accounting dimension
...
(cherry picked from commit 77deac4fb9 )
# Conflicts:
# erpnext/accounts/doctype/purchase_invoice/test_purchase_invoice.py
2023-08-18 07:08:20 +00:00
Gursheen Anand
2c8c3a022c
fix: divide offsetting amount only when account exists
...
(cherry picked from commit 3a3ffa2307 )
2023-08-18 07:08:19 +00:00
Gursheen Anand
1269f2d301
fix: divide offsetting amount for multiple dimensions
...
(cherry picked from commit 1e1e4b93c1 )
2023-08-18 07:08:19 +00:00
Gursheen Anand
11ba553dbd
fix: dict value for dimension for gl entries defined without the dimension
...
(cherry picked from commit ed3bef1840 )
2023-08-18 07:08:19 +00:00
Gursheen Anand
248d4082c0
test: TB report balanced whenfiltered using acc dimension
...
(cherry picked from commit 4004427892 )
2023-08-18 07:08:19 +00:00
Gursheen Anand
f578c3219d
fix: make offsetting entry for all doctypes
...
(cherry picked from commit 22ba12172f )
2023-08-18 07:08:18 +00:00
Gursheen Anand
c1f1a21714
fix: fetch accounting dimension details specific to company
...
(cherry picked from commit 4e09de4db2 )
2023-08-18 07:08:18 +00:00
Gursheen Anand
3198f2669d
fix: make offsetting entry for acc dimensions
...
(cherry picked from commit d3759b3971 )
2023-08-18 07:08:18 +00:00
Deepesh Garg
a623469778
Merge pull request #36645 from frappe/mergify/bp/version-14-hotfix/pr-36495
...
fix: Document Name link validation in Bank Reconciliation Tool (#36495 )
2023-08-18 09:27:10 +05:30
Deepesh Garg
ee5a1d91ff
chore: resolve conflicts
2023-08-17 20:45:53 +05:30
mergify[bot]
0a4947a8f6
fix(ux): change batch selection message to alert (backport #36500 ) ( #36697 )
...
fix(ux): change batch selection message to alert (#36500 )
* fix(ux): change batch selection message to alert
* chore: linters
(cherry picked from commit 641fe7738c )
Co-authored-by: Dany Robert <danyrt@wahni.com >
2023-08-17 18:03:58 +05:30
Frappe PR Bot
2aa3b30b56
chore(release): Bumped to Version 14.35.1
...
## [14.35.1](https://github.com/frappe/erpnext/compare/v14.35.0...v14.35.1 ) (2023-08-17)
### Bug Fixes
* **ux:** change batch selection message to alert ([#36500 ](https://github.com/frappe/erpnext/issues/36500 )) ([641fe77 ](641fe7738c ))
v14.35.1
2023-08-17 12:32:49 +00:00
Dany Robert
641fe7738c
fix(ux): change batch selection message to alert ( #36500 )
...
* fix(ux): change batch selection message to alert
* chore: linters
2023-08-17 18:01:15 +05:30
mergify[bot]
9668615f7e
feat: Tick on checkbox to include draft timesheets (backport #36577 ) ( #36640 )
...
feat: Tick on checkbox to include draft timesheets (#36577 )
feat: Tick on Check box to include Draft Timesheets
(cherry picked from commit 75652799cd )
Co-authored-by: ViralKansodiya <141210323+viralkansodiya@users.noreply.github.com >
2023-08-17 17:13:51 +05:30
Deepesh Garg
506ac10119
Merge pull request #36678 from frappe/mergify/bp/version-14-hotfix/pr-36677
...
fix(UX): Ignore prepared report (#36677 )
2023-08-17 16:08:36 +05:30
mergify[bot]
36147ec02c
fix(RFQ): make "update password" and "submit quotation" buttons the same size (backport #36667 ) ( #36686 )
...
fix(RFQ): make "update password" and "submit quotation" buttons the same size (#36667 )
fix(RFQ): button styling
Co-authored-by: Raffael Meyer <14891507+barredterra@users.noreply.github.com >
2023-08-17 16:00:17 +05:30
Shariq Ansari
3dd642441b
Merge pull request #36689 from frappe/mergify/bp/version-14-hotfix/pr-36685
...
fix: check tax and charges if it is passed (backport #36685 )
2023-08-17 13:10:42 +05:30
Shariq Ansari
f186015f58
chore: linter fix
...
(cherry picked from commit 21c1141fdb )
2023-08-17 07:40:10 +00:00
Shariq Ansari
1f76c6972b
fix: check tax and charges if it is passed
...
(cherry picked from commit 7ec6909159 )
2023-08-17 07:40:10 +00:00
mergify[bot]
c308bd5309
feat(RFQ): make email message fully configurable (backport #36353 ) ( #36531 )
...
* feat(RFQ): make email message fully configurable (#36353 )
feat: make RFQ message fully configurable
(cherry picked from commit 21080afd92 )
* fix(RFQ): hide description in print and report
---------
Co-authored-by: Raffael Meyer <14891507+barredterra@users.noreply.github.com >
2023-08-17 12:11:37 +05:30
ruthra kumar
3f33d4cf76
chore: resolve conflicts
2023-08-17 11:07:59 +05:30
ruthra kumar
47345e81a1
perf: pull latest details only for referenced vouchers
...
(cherry picked from commit deb0d71294 )
# Conflicts:
# erpnext/accounts/doctype/payment_entry/payment_entry.py
2023-08-17 03:31:54 +00:00
Deepesh Garg
3e23e1fb91
fix(UX): Ignore prepared report
...
(cherry picked from commit 124c0dbd88 )
2023-08-16 16:03:01 +00:00
ruthra kumar
b6134749c3
chore: resolve conflict
2023-08-16 16:44:07 +05:30
ruthra kumar
f8d6fe6be0
feat: utility to repost accounting ledgers without cancellation ( #36469 )
...
* feat: introduce doctypes for repost
* refactor: basic filters and validations
* chore: basic validations
* chore: added barebones function to generate ledger entries
* chore: repost on submit
* chore: repost in background
* chore: include payment entry and journal entry
* chore: ignore repost doc on cancel
* chore: preview method
* chore: rudimentary form of preview
* refactor: preview template
* refactor: basic background colors to differentiate old and new
* chore: remove commented code
* test: basic functionality
* chore: fix conflict
* chore: prevent repost on invoices with deferred accounting
* refactor(test): rename and test basic validations and methods
* refactor(test): test all validations
* fix(test): use proper name account name
* refactor(test): fix failing test case
* refactor(test): clear old entries
* refactor(test): simpler logic to clear old records
* refactor(test): make use of deletion flag
* refactor(test): split into multiple test cases
(cherry picked from commit e64b004eca )
# Conflicts:
# erpnext/accounts/doctype/journal_entry/journal_entry.js
2023-08-16 11:04:45 +00:00
Frappe PR Bot
b773465b41
chore(release): Bumped to Version 14.35.0
...
# [14.35.0](https://github.com/frappe/erpnext/compare/v14.34.3...v14.35.0 ) (2023-08-16)
### Bug Fixes
* Allow backdated repayment cancels for term loans ([1377cf4 ](1377cf4cf1 ))
* allow negative stock condition for batch item ([#36586 ](https://github.com/frappe/erpnext/issues/36586 )) ([ee04c6d ](ee04c6d5c5 ))
* AR/AP report based on payment terms ([#36574 ](https://github.com/frappe/erpnext/issues/36574 )) ([ac0fff7 ](ac0fff7e94 ))
* better remarks on Cr note created by Reconciliation ([5443592 ](5443592d84 ))
* Button Alignment center in hero slider ([#36607 ](https://github.com/frappe/erpnext/issues/36607 )) ([b131f70 ](b131f70ed6 )), closes [#36561 ](https://github.com/frappe/erpnext/issues/36561 )
* cr/dr note should be posted for exc gain/loss ([349601b ](349601b4b9 ))
* disallow mulitple SO with same PO No ([b901cfd ](b901cfdbe2 ))
* don't show disabled items in `Item Shortage Report` (backport [#36550 ](https://github.com/frappe/erpnext/issues/36550 )) ([#36571 ](https://github.com/frappe/erpnext/issues/36571 )) ([19cfcea ](19cfcea78e ))
* fetch `Stock UOM` from Item if not set (backport [#36606 ](https://github.com/frappe/erpnext/issues/36606 )) ([#36617 ](https://github.com/frappe/erpnext/issues/36617 )) ([8b13185 ](8b13185c25 ))
* Group Account total not showing in Financial Statements ([2912648 ](2912648151 ))
* incorrect available qty for backdated stock reco with batch ([#36581 ](https://github.com/frappe/erpnext/issues/36581 )) ([2800ad3 ](2800ad39d2 ))
* incorrect gain/loss on allocation change on reconciliation tool ([39c439d ](39c439dc4b ))
* Make default sales update frequency as monthly instead of each transaction ([4ca1f3b ](4ca1f3b9cf ))
* move company rename to long queue ([8083c0b ](8083c0b59e ))
* precision issue while submitting the stock entry ([#36575 ](https://github.com/frappe/erpnext/issues/36575 )) ([a864e07 ](a864e07d4f ))
* re-add permission that was unintentionally removed ([#36663 ](https://github.com/frappe/erpnext/issues/36663 )) ([99777d3 ](99777d3fa4 ))
* **RFQ:** link to supplier portal ([eb2f68e ](eb2f68ec98 ))
* standard formula to calculate the "difference" ([#36612 ](https://github.com/frappe/erpnext/issues/36612 )) ([716d5c0 ](716d5c0b98 ))
* Tax withholding post LDC limit consumed ([#36611 ](https://github.com/frappe/erpnext/issues/36611 )) ([1deebe8 ](1deebe8757 ))
* **test:** replace hardcoded reference to adv with dynamic one ([2e6bfa3 ](2e6bfa36de ))
* **test:** test case breakage in Github Actions ([3542df7 ](3542df70f6 ))
* unhide `uom` and `stock_uom` fields in print view ([b49309c ](b49309c160 ))
* validation blocks partial payment for SO and PO ([ce08f03 ](ce08f038d2 ))
* wrap none type rate under flt (backport [#36602 ](https://github.com/frappe/erpnext/issues/36602 )) ([#36604 ](https://github.com/frappe/erpnext/issues/36604 )) ([63c061e ](63c061e5e8 ))
* wrong currency on financial-statement based reports ([#36524 ](https://github.com/frappe/erpnext/issues/36524 )) ([3044f46 ](3044f46c52 ))
### Features
* add voucher totals in tds payable report ([#36568 ](https://github.com/frappe/erpnext/issues/36568 )) ([90b390c ](90b390c2c5 ))
* daily asset depreciation method ([#36587 ](https://github.com/frappe/erpnext/issues/36587 )) ([2918127 ](29181274c8 ))
* Reallow customizing company abbreviation on setup. ([#36646 ](https://github.com/frappe/erpnext/issues/36646 )) ([ca34b63 ](ca34b63470 ))
### Performance Improvements
* **invoice:** Faster return amount query (backport [#36556 ](https://github.com/frappe/erpnext/issues/36556 )) ([#36557 ](https://github.com/frappe/erpnext/issues/36557 )) ([fe41be9 ](fe41be953d ))
v14.35.0
2023-08-16 06:34:09 +00:00
Deepesh Garg
787118d00b
Merge pull request #36658 from frappe/version-14-hotfix
...
chore: release v14
2023-08-16 12:02:35 +05:30
Deepesh Garg
67c8350f70
Merge branch 'version-14' into version-14-hotfix
2023-08-16 11:08:08 +05:30
ruthra kumar
cba1c63beb
Merge pull request #36651 from frappe/mergify/bp/version-14-hotfix/pr-36642
...
refactor: toggle for negative item rates in Selling Settings (backport #36642 )
2023-08-16 10:30:24 +05:30
ruthra kumar
2f0e7fcb4a
Merge branch 'version-14-hotfix' into mergify/bp/version-14-hotfix/pr-36642
2023-08-16 09:58:31 +05:30
ruthra kumar
44c1b91ca7
Merge pull request #36633 from frappe/mergify/bp/version-14-hotfix/pr-35644
...
refactor: booking exchange gain/loss amount through journal (backport #35644 )
2023-08-16 09:41:25 +05:30
mergify[bot]
1deebe8757
fix: Tax withholding post LDC limit consumed ( #36611 )
...
* fix: Tax withholding post LDC limit consumed (#36611 )
* fix: Tax withholding post LDC limit consumed
* fix: LDC condition check
(cherry picked from commit 985ff9781b )
# Conflicts:
# erpnext/accounts/doctype/tax_withholding_category/test_tax_withholding_category.py
* chore: resolve conflicts
* chore: linting issues
---------
Co-authored-by: Deepesh Garg <deepeshgarg6@gmail.com >
2023-08-16 08:09:38 +05:30
mergify[bot]
99777d3fa4
fix: re-add permission that was unintentionally removed ( #36663 )
...
fix: re-add permission that was unintentionally removed
Remove `Reversal OF ITC` and re-add permissions. Both of them
unintended changes
(cherry picked from commit 45662fa646 )
Co-authored-by: ruthra kumar <ruthra@erpnext.com >
2023-08-16 08:09:04 +05:30
mergify[bot]
33d5250cec
chore: add validation for depreciation expense account in asset category (backport #36659 ) ( #36661 )
...
chore: add validation for depreciation expense account in asset category (#36659 )
(cherry picked from commit e0c79d3b53 )
Co-authored-by: Anand Baburajan <anandbaburajan@gmail.com >
2023-08-15 18:27:01 +05:30
ruthra kumar
e55c160438
chore: resolve conflicts
2023-08-15 08:56:37 +05:30
ruthra kumar
3a82eb4ccf
refactor: toggle for negative rates in Selling Settings
...
(cherry picked from commit a0fc68538f )
# Conflicts:
# erpnext/accounts/doctype/sales_invoice/test_sales_invoice.py
# erpnext/patches.txt
# erpnext/selling/doctype/selling_settings/selling_settings.json
2023-08-15 02:43:54 +00:00
Devin Slauenwhite
ca34b63470
feat: Reallow customizing company abbreviation on setup. ( #36646 )
...
Co-authored-by: Bernd Oliver Sünderhauf <pancho@mailbox.org >
2023-08-14 21:44:03 +05:30
Kevin Shenk
83cbc1bef6
fix: Document Name link validation in Bank Reconciliation Tool ( #36495 )
...
fix: format_row broke Document Name link validation
#35540 broke Voucher Matching, leading to an invalid link exception on submission. This is because the format_row() function overwrites the row data instead of just providing a formatter on the DataTable column, and therefore passes through the formatted (linked) column data instead of the Document Name only.
This patch moves the appropriate frappe.form.formatters.Link function to a dedicated format hook on the DataTable columns definition, both fixing the error and retaining the functionality of #35540 .
(cherry picked from commit 7ab55b1bb2 )
# Conflicts:
# erpnext/public/js/bank_reconciliation_tool/dialog_manager.js
2023-08-14 13:34:31 +00:00
mergify[bot]
716d5c0b98
fix: standard formula to calculate the "difference" ( #36612 )
...
fix: standard formula to calculate the "difference" (#36612 )
(cherry picked from commit 843e77e72d )
Co-authored-by: HarryPaulo <paulo_fabris@hotmail.com >
2023-08-14 18:55:16 +05:30