ruthra kumar
80f4a11d60
Merge pull request #35353 from frappe/mergify/bp/version-14-hotfix/pr-35335
...
fix: tds incorrectly calculated for invoice that are below threshold (backport #35335 )
2023-05-18 13:03:40 +05:30
Sagar Sharma
9caa39195c
Merge pull request #35344 from frappe/mergify/bp/version-14-hotfix/pr-35306
...
fix: Pick List Status (backport #35306 )
2023-05-18 12:52:25 +05:30
ruthra kumar
879946e2c8
fix(test): cumulative threshold checks
...
(cherry picked from commit 132846bbd1 )
2023-05-18 07:09:20 +00:00
ruthra kumar
bdf81a43c6
fix: tds incorrectly calculated for invoice that are below threshold
...
Two purchase invoices for the same supplier, using different tax
withholding categories have this issue.
| Category | single | cumulative |
|----------+--------+------------|
| cat1 | 100 | 500 |
| cat2 | 1000 | 5000 |
1. PINV1 of net total: 105/- uses cat1. TDS is calculated as it
breached single threshold
2. PINV2 of net total: 200/- uses cat2. TDS incorrectly calculated as
PINV1 already has TDS calculated and 'consider_party_ledger_amount' is enabled.
(cherry picked from commit 84b7c1bba0 )
2023-05-18 07:09:19 +00:00
Sagar Sharma
cb681e0b96
Merge branch 'version-14-hotfix' into mergify/bp/version-14-hotfix/pr-35306
2023-05-18 12:30:40 +05:30
ruthra kumar
65554bdabf
Merge pull request #35336 from frappe/mergify/bp/version-14-hotfix/pr-35239
...
fix: in payment_entry difference amount cal is broken (backport #35239 )
2023-05-18 12:15:44 +05:30
rohitwaghchaure
0d2d45f32f
Merge pull request #35351 from frappe/mergify/bp/version-14-hotfix/pr-35298
...
fix: Creating landed cost voucher from connections (backport #35298 )
2023-05-18 06:16:11 +05:30
vishnu
2631224e49
fix: Creating landed cost voucher from connections
...
(cherry picked from commit f2ceb00379 )
2023-05-18 00:43:36 +00:00
Anand Baburajan
0a080efce2
fix: depreciation schedule for existing assets [v14] ( #35255 )
...
* fix: depreciation schedule for existing assets
* chore: correct logic for existing assets and fix test
2023-05-17 22:21:00 +05:30
Sagar Sharma
48884366ea
fix: Pick List Status
...
(cherry picked from commit 9fb8b1827d )
2023-05-17 12:43:08 +00:00
mergify[bot]
15c1af3d8a
fix: consider 0 if rate/qty are null (backport #35338 ) ( #35340 )
...
fix: consider 0 if rate/qty are null (#35338 )
[skip ci]
(cherry picked from commit e5c86bc2e8 )
Co-authored-by: Ankush Menat <ankush@frappe.io >
2023-05-17 16:17:21 +05:30
Sagar Sharma
350f75877a
Merge pull request #35339 from frappe/mergify/bp/version-14-hotfix/pr-35337
...
fix(ux): SCR consumed-qty read-only property (backport #35337 )
2023-05-17 15:58:29 +05:30
Sagar Sharma
aa7fede0dc
fix(ux): SCR consumed-qty read-only property
...
(cherry picked from commit adf2474d9d )
2023-05-17 10:28:03 +00:00
Ashish Shah
e9f2ab5caf
refactor: use 'flt' for base_total_taxes_and_charges
...
difference_amount calculation is broken, as calculation gives NaN. Fix is make frm.doc.base_total_taxes_and_charges as flt(frm.doc.base_total_taxes_and_charges)
(cherry picked from commit ae4e56747c )
2023-05-17 09:40:55 +00:00
Frappe PR Bot
7076c23a4f
chore(release): Bumped to Version 14.24.2
...
## [14.24.2](https://github.com/frappe/erpnext/compare/v14.24.1...v14.24.2 ) (2023-05-16)
### Bug Fixes
* add missing options for `Content Align` ([3697e8f ](3697e8f1f9 ))
* allow over-payment against SO ([#35079 ](https://github.com/frappe/erpnext/issues/35079 )) ([fe9e0c2 ](fe9e0c2121 ))
* bad strings format for command get-untraslated ([#34361 ](https://github.com/frappe/erpnext/issues/34361 )) ([5a54296 ](5a54296686 ))
* bad strings format for update-translations ([#34592 ](https://github.com/frappe/erpnext/issues/34592 )) ([e3c1d73 ](e3c1d736ce ))
* bom item filter issue ([098603d ](098603dd35 ))
* cancelled vouchers in tax withheld vouchers list ([#35309 ](https://github.com/frappe/erpnext/issues/35309 )) ([c41e1d7 ](c41e1d7d71 ))
* enqueue submit/cancel action for stock entry to avoid time out error ([457846e ](457846e34c ))
* force to do reposting for cancelled document ([6f96e5d ](6f96e5dcd4 ))
* function `batch_no` should only be declared once ([#35115 ](https://github.com/frappe/erpnext/issues/35115 )) ([26928b3 ](26928b395b ))
* incorrect packing items ([ab56470 ](ab56470171 ))
* inventory dimension for inter company transfer return use case ([6d121b8 ](6d121b8107 ))
* inventory dimension for material transfer not working ([1d8050d ](1d8050d24d ))
* item list view not working ([d9efa66 ](d9efa662d4 ))
* port option for additional_conditions in item wise sales register ([#35187 ](https://github.com/frappe/erpnext/issues/35187 )) ([42037f9 ](42037f9f73 ))
* recalculate costs in SCR while reposting ([9a8ee62 ](9a8ee62d5a ))
* sales person allocated amount calculation error nonetype and float ([#35293 ](https://github.com/frappe/erpnext/issues/35293 )) ([3a7c69f ](3a7c69fc71 ))
* test case ([3f8928b ](3f8928be5c ))
* test case ([9b2b467 ](9b2b46737e ))
* typo ([2772a91 ](2772a911ed ))
* unable to create partial invoice with auto fetch terms enabled ([#35285 ](https://github.com/frappe/erpnext/issues/35285 )) ([fa9fa97 ](fa9fa97e05 ))
* update workstation hour rate when workstation change in job card ([bc88415 ](bc88415e73 ))
* **UX:** misc "home" onboarding improvements (backport [#35319 ](https://github.com/frappe/erpnext/issues/35319 )) ([#35321 ](https://github.com/frappe/erpnext/issues/35321 )) ([f8c58b6 ](f8c58b6893 ))
* validate for active sla ([#32132 ](https://github.com/frappe/erpnext/issues/32132 )) ([38e27a6 ](38e27a68d5 ))
### Performance Improvements
* cache and simplify queries for holiday list (backport [#35315 ](https://github.com/frappe/erpnext/issues/35315 )) ([#35318 ](https://github.com/frappe/erpnext/issues/35318 )) ([0e78403 ](0e7840301f ))
v14.24.2
2023-05-16 17:00:00 +00:00
Deepesh Garg
bdfd682664
Merge pull request #35324 from frappe/version-14-hotfix
...
chore: release v14
2023-05-16 22:28:33 +05:30
Anoop
fb0f82eed3
Merge branch 'version-14-hotfix' into gross-and-net-profit-fix
2023-05-16 20:10:23 +05:30
mergify[bot]
fa9fa97e05
fix: unable to create partial invoice with auto fetch terms enabled ( #35285 )
...
fix: unable to create partial invoice with auto fetch terms enabled (#35285 )
fix: fetch so/po terms if auto fetch is enabled
(cherry picked from commit 0da6c1688b )
Co-authored-by: ruthra kumar <ruthra@erpnext.com >
2023-05-16 18:59:12 +05:30
mergify[bot]
c41e1d7d71
fix: cancelled vouchers in tax withheld vouchers list ( #35309 )
...
fix: cancelled vouchers in tax withheld vouchers list (#35309 )
(cherry picked from commit 776a83066d )
Co-authored-by: ruthra kumar <ruthra@erpnext.com >
2023-05-16 18:58:04 +05:30
rohitwaghchaure
8f8c0a597b
Merge pull request #35329 from frappe/mergify/bp/version-14-hotfix/pr-35328
...
fix: force to do reposting for cancelled document (backport #35328 )
2023-05-16 18:53:33 +05:30
Rohit Waghchaure
6f96e5dcd4
fix: force to do reposting for cancelled document
...
(cherry picked from commit 6e661e7c0e )
2023-05-16 12:03:43 +00:00
mergify[bot]
f8c58b6893
fix(UX): misc "home" onboarding improvements (backport #35319 ) ( #35321 )
...
fix(UX): misc "home" onboarding improvements (#35319 )
* fix(UX): cleanup "Home" onboarding
- Remove company, letterhead, data import etc from home onboarding step
* fix(UX): Show quick entry for item
* chore: fix copy here and there
(cherry picked from commit 5574d9a72d )
Co-authored-by: Ankush Menat <ankush@frappe.io >
2023-05-16 16:00:25 +05:30
mergify[bot]
0e7840301f
perf: cache and simplify queries for holiday list (backport #35315 ) ( #35318 )
...
Co-authored-by: Rucha Mahabal <ruchamahabal2@gmail.com >
2023-05-16 13:44:35 +05:30
Anoop Kurungadam
cb9b4fbb91
fix: add total col for gross and net profit
2023-05-16 12:08:42 +05:30
Anoop Kurungadam
1a3b9c5bdf
refactor: merge separate loops for calculating group / leaf node totals
...
rename function
remove return statement as the list is mutated
2023-05-16 12:08:32 +05:30
Anoop Kurungadam
50822f207e
refactor: remove unused parameters
2023-05-16 12:08:24 +05:30
Anoop Kurungadam
8dcb9302b4
fix: account group totals calculation to consider include_in_gross
2023-05-16 12:08:17 +05:30
rohitwaghchaure
19f08afcef
Merge pull request #35314 from frappe/mergify/bp/version-14-hotfix/pr-35312
...
fix: item list view not working (backport #35312 )
2023-05-16 11:10:18 +05:30
mergify[bot]
42037f9f73
fix: port option for additional_conditions in item wise sales register ( #35187 )
...
fix: port option for additional_conditions in item wise sales register (#35187 )
Co-authored-by: Deepesh Garg <deepeshgarg6@gmail.com >
(cherry picked from commit 2a609616d9 )
Co-authored-by: Smit Vora <smitvora203@gmail.com >
2023-05-16 07:29:48 +05:30
Rohit Waghchaure
d9efa662d4
fix: item list view not working
...
(cherry picked from commit 0489e30244 )
2023-05-15 19:40:23 +00:00
rohitwaghchaure
ee147e62d5
Merge pull request #35311 from CodeVenturers/version-14-hotfix
...
fix: update workstation hour rate when workstation change in job card
2023-05-16 00:44:26 +05:30
vishnu
bc88415e73
fix: update workstation hour rate when workstation change in job card
2023-05-15 14:50:40 +00:00
Sagar Sharma
5463f0b137
Merge pull request #35308 from frappe/mergify/bp/version-14-hotfix/pr-35138
...
fix: recalculate costs in SCR while reposting (backport #35138 )
2023-05-15 17:14:57 +05:30
Sagar Sharma
a8fc17e0ae
refactor: use calculate_items_qty_and_amount() to update scr items rate
...
(cherry picked from commit 9c72c2a6cb )
2023-05-15 10:56:51 +00:00
Sagar Sharma
0575b105d0
refactor(minor): rename function to be more descriptive
...
(cherry picked from commit d6433f803b )
2023-05-15 10:56:51 +00:00
Sagar Sharma
4c8dbeddec
test: add test case
...
(cherry picked from commit e0b22edb2e )
2023-05-15 10:56:51 +00:00
s-aga-r
9a8ee62d5a
fix: recalculate costs in SCR while reposting
...
(cherry picked from commit a6cb6c6f47 )
2023-05-15 10:56:50 +00:00
mergify[bot]
3a7c69fc71
fix: sales person allocated amount calculation error nonetype and float ( #35293 )
...
fix: sales person allocated amount calculation error nonetype and float (#35293 )
fix: sales person allocated amount calculation error nontype and float
(cherry picked from commit 0c8276ec82 )
Co-authored-by: Indrajith.vs <91895505+Gubbu77@users.noreply.github.com >
2023-05-15 13:16:47 +05:30
rohitwaghchaure
dd116a3071
Merge pull request #35291 from frappe/mergify/bp/version-14-hotfix/pr-35289
...
fix: inventory dimension for returned inter company transfer (backport #35289 )
2023-05-14 16:29:34 +05:30
rohitwaghchaure
3f8928be5c
fix: test case
2023-05-14 15:49:58 +05:30
mergify[bot]
26928b395b
fix: function batch_no should only be declared once ( #35115 )
...
fix: function `batch_no` should only be declared once (#35115 )
fix: remove twice event call of `batch_no` to update batch qty
(cherry picked from commit 19cd687784 )
Co-authored-by: Daizy Modi <modidaizy5217@gmail.com >
2023-05-14 11:54:15 +05:30
mergify[bot]
fe9e0c2121
fix: allow over-payment against SO ( #35079 )
...
fix: allow over-payment against SO (#35079 )
(cherry picked from commit 870b02b03c )
Co-authored-by: Raffael Meyer <14891507+barredterra@users.noreply.github.com >
2023-05-14 11:44:50 +05:30
Deepesh Garg
77cf2e5475
Merge pull request #35262 from akiratfli/fix-bad-string
...
fix: bad strings format for translations
2023-05-14 08:06:24 +05:30
rohitwaghchaure
2772a911ed
fix: typo
2023-05-13 15:14:41 +05:30
Rohit Waghchaure
6d121b8107
fix: inventory dimension for inter company transfer return use case
...
(cherry picked from commit 38aaba5720 )
2023-05-13 08:57:03 +00:00
Sagar Sharma
c30dda3328
Merge pull request #35283 from frappe/mergify/bp/version-14-hotfix/pr-35275
...
fix: add missing options for `Content Align` (backport #35275 )
2023-05-13 09:42:20 +05:30
Sagar Sharma
b2e6fdc0cb
Merge branch 'version-14-hotfix' into mergify/bp/version-14-hotfix/pr-35275
2023-05-13 09:41:30 +05:30
rohitwaghchaure
75af689f77
Merge pull request #35282 from frappe/mergify/bp/version-14-hotfix/pr-35224
...
fix: inventory dimension for material transfer not working (backport #35224 )
2023-05-13 09:36:42 +05:30
Sagar Sharma
3697e8f1f9
fix: add missing options for Content Align
...
(cherry picked from commit d16caa2d2c )
2023-05-13 04:05:15 +00:00
Rohit Waghchaure
1d8050d24d
fix: inventory dimension for material transfer not working
...
(cherry picked from commit 6798b900ef )
2023-05-12 20:46:04 +00:00