More RTC cleanup (#1115)

* reduce create_peer_connection like crazy

* turns out that we dont event and callback/while+sleep magic for create_sdp_offer and negotiate_sdp_answer

* test for audio/video to peers

* flag rtc methods to be revised

* fix lint
This commit is contained in:
Henry Ruhs
2026-05-15 15:10:51 +02:00
committed by GitHub
parent ad3b582c49
commit 532464032b
3 changed files with 67 additions and 71 deletions
+1 -1
View File
@@ -132,7 +132,7 @@ def test_stream_video(test_client : TestClient, create_event : threading.Event,
websocket.send_bytes(chr(1).encode() + source_content)
websocket.receive_text()
peer_connection = rtc.create_peer_connection(disable_auto_negotiation = True)
peer_connection = rtc.create_peer_connection()
rtc.add_video_track(peer_connection, 'recvonly', 'vp8', 96)
rtc.add_audio_track(peer_connection, 'recvonly', 'opus', 111)
sdp_offer = rtc.create_sdp_offer(peer_connection)
+39 -1
View File
@@ -25,7 +25,7 @@ def test_create_peer_connection() -> None:
def test_create_sdp_offer() -> None:
peer_connection = rtc.create_peer_connection(disable_auto_negotiation = True)
peer_connection = rtc.create_peer_connection()
rtc.add_video_track(peer_connection, 'sendonly', 'vp8', 96)
rtc.add_audio_track(peer_connection, 'sendonly', 'opus', 111)
sdp_offer = rtc.create_sdp_offer(peer_connection)
@@ -64,6 +64,44 @@ def test_negotiate_sdp_answer() -> None:
assert datachannel_library.rtcDeletePeerConnection(receiver_connection) == 0
# TODO: review
def test_send_audio_to_peers() -> None:
datachannel_library = datachannel_module.create_static_library()
peer_connection = rtc.create_peer_connection()
audio_track = rtc.add_audio_track(peer_connection, 'sendonly', 'opus', 111)
rtc_peers : List[RtcPeer] =\
[
{
'peer_connection': peer_connection,
'video_track': 0,
'audio_track': audio_track
}
]
rtc.send_audio_to_peers(rtc_peers, bytes(960), 0)
datachannel_library.rtcDeletePeerConnection(peer_connection)
# TODO: review
def test_send_video_to_peers() -> None:
datachannel_library = datachannel_module.create_static_library()
peer_connection = rtc.create_peer_connection()
video_track = rtc.add_video_track(peer_connection, 'sendonly', 'vp8', 96)
rtc_peers : List[RtcPeer] =\
[
{
'peer_connection': peer_connection,
'video_track': video_track,
'audio_track': 0
}
]
rtc.send_video_to_peers(rtc_peers, bytes(1024))
datachannel_library.rtcDeletePeerConnection(peer_connection)
def test_delete_peers() -> None:
datachannel_library = datachannel_module.create_static_library()
peer_connection = rtc.create_peer_connection()